Skip to content

docs(responses): register and document citation replay coverage - #7608

Closed
Ingwannu wants to merge 2 commits into
devfrom
chore/citation-replay-contract-7573
Closed

Ingwannu wants to merge 2 commits into
devfrom
chore/citation-replay-contract-7573

Conversation

@Ingwannu

@Ingwannu Ingwannu commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

Register the existing URL-citation replay regression in both test inventories and document the outbound citation projection introduced by #7573. The decoded-checkpoint contract now distinguishes checkpoint framing from citation repair on OpenAI-operated outbound history. This changes documentation and test registration only.

The branch merges trusted dev@6672cfb4a2b9a1dc72e26ed159c1d70368fe0ca7, preserving #7607's layout size repair and the subsequent test-layout shards. The original runtime fix is already on dev; no runtime reimplementation or file-size limit increase is included.

Verification

Updated head: 5b3b87894cf6e2b0e7e70ae1f0b795f728edafec. Validation ran on the resulting merged tree with official Bun 1.4.4+38afee6c8, a frozen install with lifecycle scripts disabled, private temporary homes, and one CPU/RAM/process-limited workload at a time.

  • bun test --isolate tests/responses/responses-url-citation-title-repair.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts: 47 pass, 0 fail, 685 assertions. This includes the size gate that failed on the old head.
  • bun scripts/structure-ssot.ts --fix and bun scripts/structure-ssot.ts: exit 0; generated index agrees with the manifest.
  • bun scripts/privacy-scan.ts: exit 0 (ordinary repository privacy gate).
  • git diff --check: exit 0.
  • Typecheck (bun node_modules/typescript/bin/tsc --noEmit): incomplete; the enforced 300-second workload deadline killed it (about 1.2 GiB peak; no successful result). Limits were not raised. The Bun dependency wrapper's ignored postinstall was not used.
  • Full local suite is deferred because it is disproportionate for this documentation/registration-only patch under this host's limits. Focused citation, inventory and ratchet coverage above passed; replacement-head hosted CI is still required and is not claimed passing.

No live provider request, client-file synchronization, service restart, security scanner, merge, release or deployment was performed. The main dirty checkout and protected runtime configuration were preserved. The push used core.hooksPath=/dev/null; the explicit checks and incomplete typecheck are recorded above.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Existing runtime/credential behavior is unchanged; ordinary repository privacy gate passed.

This PR remains Draft pending successful typecheck/current-head CI and review readiness. Previous-head CI results do not qualify the new head.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 23, 2026
@lidge-jun

Copy link
Copy Markdown
Owner

Triage note (2026-10-24, against dev at 2494848).

Needs fixes before this can land: refresh onto dev containing #7607, preserve its size repair, obtain passing replacement-head CI, and complete draft readiness. No runtime reimplementation is needed.

Still needed on dev: partial. Runtime repair already landed through #7573 / 9a34e21482, including src/adapters/openai-responses/request-strips.ts:54. Explicit registration and the documentation correction remain absent; the existing broad statement is at structure/transports/responses.md:401.

Exact-head CI at triage time: 139b0c4 — 17 success, 10 skipped; test 2/4 and ci fail in run 39919488485. Failure is layout.json at 2,000 lines. lane=all on exact head: n.a.

Please refresh onto current dev when addressing these; heads older than dev need a fresh exact-head CI run before review.

@lidge-jun

Copy link
Copy Markdown
Owner

Carried onto current dev as #7865 with a Co-authored-by trailer for you: the structure doc, manifest entry, responses.md link and test registration, with the dev conflicts (manifest, responses.md, generated index) resolved by keeping both sides. This PR will be closed once #7865 lands.

lidge-jun added a commit that referenced this pull request Oct 28, 2026
Carries #7608 onto current dev: adds the response-citations structure
doc, links it from responses.md and registers the existing
url-citation title-repair regression in the test layout.

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>
Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com>
@lidge-jun

Copy link
Copy Markdown
Owner

Landed on dev through the carry #7865 (squash d67fedd) with a Co-authored-by trailer for you. Thank you.

@lidge-jun lidge-jun closed this Oct 28, 2026
@lidge-jun
lidge-jun deleted the chore/citation-replay-contract-7573 branch November 8, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants