Repository navigation
fix(desktop): bind usage trials to fresh package proof - #7709
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration decision for v2.93.0 release prep: MERGED into Independent security/correctness review: gpt-6.1-sol (high reasoning), task Exact-head CI on
Combined tree (this head merged with current Scope stays as described: package-proof binding only. The supported version, default-off behavior, the three-minute trial bound and explicit consent are unchanged, and the broader #7587 work remains open. NOT RUN: full local suite (resource exception; parallel release lanes), live Appx/installed-package proof, real Codex App trial. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Bind desktop compatibility trial consent to fresh observations of the registered package manifest App entry and executable. An observed identity change or failed proof clears consent, exhaustion observations and corrected outputs; returning to the previous identity does not restore consent. Reject reparse ancestry, fence late probes after runtime replacement, and keep private package proof out of public status.
This implements only the package-proof safety portion of #7587. The supported version
26.924.2738.0, default-off behavior, maximum three-minute trial, fresh exhaustion and explicit account-wide consent remain unchanged. Provider isolation remains unavailable. Launcher, trust and authentication behavior are unchanged.Head
a75e94abbee20896e171d337e5402e6708031213normally merges dev8ebe46b2076445d100cef1e52af4d98d78f8f1e1into the previous public head999b63ff. The seven child-specific blobs remain byte-identical; the merged registration/layout state was checked separately.Verification
On this exact head, official Windows Bun 1.4.4 with isolated test homes and the existing CI timeout contract:
The tests use synthetic package proof/identity data, temporary junction fixtures, loopback CONNECT/TLS/SSE and in-memory certificates. No live Appx query, certificate-store change, installed-app launch or real account trial was performed. Exact-head automatic CI 40229067628 passed; conditional platform skips are not live integration evidence.
Metadata walks are observations, not held-handle identity, signature verification or process attestation. They cannot exclude transient replacement between observations or a reinstall preserving all observed metadata. Actual Appx/consumer/cache/native-turn behavior and OS trust remain unverified.
Checklist
This PR remains Draft for B/security review; broader compatibility work in #7587 remains open. No activation, deployment or merge decision is claimed.