Repository navigation
fix(antigravity): union multi-account model discovery, skip disabled wire ids, and rank initial failover by quota #7717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
andrew05060414
wants to merge
1
commit into
lidge-jun:dev
from
andrew05060414:fix/antigravity-multi-account-discovery-routing
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 Supported by static analysis
Script executed:
Repository: lidge-jun/opencodex
Length of output: 33697
Script executed:
Repository: lidge-jun/opencodex
Length of output: 14652
Add regression tests for rejected loopback paths in routing-drift detection.
loopbackEndpointinsrc/codex/routing-drift.tsaccepts a loopback URL only when its path is empty or/v1, after trailing slashes are removed. No test intests/codex-integration/injection-routing-drift.test.tsortests/cli/cli-status-codex-routing-drift.test.tscovers a rejected path such as/healthor/v1/extra. The/v1/trailing-slash case is also untested. If the check on lines 81-82 regressed, the current suite would still pass. A loopback URL on a foreign port with an unsupported path could then be reported as drift.Add the cases next to the existing non-loopback and no-port negative tests:
Suggested test additions
expect(detectCodexRoutingDrift(designB("https://hub.example.test:8443/v1"), { ownPorts: OWN })).toEqual({ kind: "none" }); }); + test("loopback paths other than the root and /v1 are ignored", () => { + expect(detectCodexRoutingDrift(designB("http://127.0.0.1:10199/health"), { ownPorts: OWN })).toEqual({ kind: "none" }); + expect(detectCodexRoutingDrift(designB("http://127.0.0.1:10199/v1/extra"), { ownPorts: OWN })).toEqual({ kind: "none" }); + }); + + test("a trailing slash on /v1 is still a foreign endpoint", () => { + expect(detectCodexRoutingDrift(designB("http://127.0.0.1:10199/v1/"), { ownPorts: OWN }).kind).toBe("foreign"); + }); + test("native config is not-owned", () => {