Skip to content

test(windows): use a never-allocated PID for the pending-child recovery fixture #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Oct 29, 2026
Merged

test(windows): use a never-allocated PID for the pending-child recovery fixture #7949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/codex-integration/codex-cli-update-windows-pending.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { afterEach, beforeAll, beforeEach, expect, spyOn, test } from "bun:test";
import { spawnSync } from "node:child_process";
import { existsSync, mkdirSync, statSync, writeFileSync } from "node:fs";
import { join } from "node:path";
import * as ffi from "bun:ffi";
Expand All @@ -23,9 +22,12 @@ type RecordBody = { version: number; token: string; parentPid: number; phase: st
windows: { jobName: string; creationTime: string | null } };
beforeAll(() => {
if (!native) return;
const child = spawnSync(process.execPath, ["-e", "console.log(process.pid)"], { encoding: "utf8", windowsHide: true });
expect(child.status).toBe(0); deadPid = Number(child.stdout.trim());
expect(() => process.kill(deadPid, 0)).toThrow();
// A PID that must stay dead for the whole file. The PID of an exited child is not: hosted Windows
// reuses PIDs quickly, and a reused parent PID made recovery fence before the publication step
// these cases inject into (dev batch 40824593871). Windows PIDs are multiples of 4 and are never
// allocated this high, so the value stays dead while remaining a valid in-range record PID.
deadPid = 0x7ffffffc;
expect(() => process.kill(deadPid, 0)).toThrow(expect.objectContaining({ code: "ESRCH" }));
});
beforeEach(async () => {
if (!native) return;
Expand Down
Loading