Repository navigation
test: quarantine hosted Windows CI failures for 2.98.0 #8264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // Temporary 2.98.0 quarantine: https://github.com/lidge-jun/opencodex/issues/8262 | ||
| export const hostedWindowsQuarantine = process.platform === "win32" && process.env.GITHUB_ACTIONS === "true"; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: lidge-jun/opencodex
Length of output: 41913
Keep a refusal case where a present service references the recovered token.
The
service-exportedcase now points its service command at/home/fixture/.opencodex/service-api-token. Recovery movesjoin(home, "service-api-token"). No remaining case covers a present service that references the recovered token.service-unknownandservice-probe-faileddo not produce a present service. The liveness-recheck test returnsabsentand thenunknown. The probe tests intests/codex-integration/codex-service-manager-probe-hardening.test.tscover the helper only, not the recovery refusal.A guard that wrongly permits services sharing the recovered token's home would still refuse the simulated service, because that service lives in a different home. The suite would still pass.
Add a separate refusal case that:
tokenPathand the testhome,presentresult,handleDisconnectCommand(["--orphaned-token", "--yes"], …)to return1with an admission refusal, and expectstokenPathto be unchanged.Keep the simulated Linux paths in
service-exported. If the real test-home path cannot be represented in the systemd fixture on Windows, limit the new case to non-Windows, as lines 298-301 already do.