Repository navigation
ci: refresh the Windows shard durations from batch 42694893702 - #8463
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
…policy Appends a ci policy entry identical to the latest one except for the new scripts/ci/test-durations.windows.tsv blob, keeping earlier entries so historical revisions still verify.
|
Merge judgment (maintainer, dev integration under the PR-only bypass in MAINTAINERS.md). Head A fresh final review approved with nits and gave the security review MAINTAINERS.md:83 asks for: trusted workflow and helper digests are unchanged; the new entry admits only runs on trees containing this exact table and still requires a successful Exact-head CI: NOT RUN: a Windows batch on this table; the next dev |
Summary
windows 9/11in dev batch 42694893702 (4b38e9a) was cancelled at the 30-minute job limit in batch 42/48. No test failed. Its first big contributor is the ocx-child Rust conformance runner: since #8458 it compiles and passes in 48 s, where before it failed in 0.5 s.scripts/ci/test-durations.windows.tsvhad no row for it, so the shard planner weighed it at the median. The table had no row for 131 files that exist today, all weighed at the median, and other rows no longer matched Windows timings, so one shard ran well past the planner's estimate.This refreshes the Windows table with
bun scripts/ci/test-durations.ts refresh --table scripts/ci/test-durations.windows.tsvfrom the eleven Windows job logs of that run: 3016 rows, 2949 measured, 67 retained. 125 of the 131 missing files gain a row; six were never reached by these logs and still weigh the median (tests/service/doctor-bun-install.test.ts,tests/update/update-bounded-json.test.ts,tests/update/update-root-snapshot.test.ts,tests/update/update-sync-mutex.test.ts,tests/usage/usage-telemetry-client.test.ts,tests/usage/usage-telemetry-collector-worker.test.ts). Two shards did not finish:8/11stopped at its failing batch and9/11was cancelled. The tool keeps the existing rows for files those logs never reached (67 rows: 40 on shard 8 and 27 on shard 9), so the refresh is partial for them; the heaviest retained row istests/windows/windows-codex-cli-job-store.test.tsat 82211 ms. The script's header asks for a fully greenlane=allrun, which dev has not had in this round; this is the closest available. The planner and the job limits are unchanged.The table is a pinned input of the release evidence policy, so this also appends a
civ1 entry to.github/scripts/release-evidence-policy.jsonthat is identical to the latest one except for the table's new blob (18c65823…), following the procedure at the top ofrelease-evidence.cjsand the precedent of #8377. Earlier entries stay, so evidence from older commits still verifies.Verification
node .github/scripts/release-evidence.cjs policy-check: fingerprints match (it reportedpolicy fingerprint mismatch: scripts/ci/test-durations.windows.tsvbefore the policy entry).node --test .github/scripts/release-evidence.test.cjs: 25 pass, 0 fail.bun testover the eighttests/ci-workflows/files that read the policy or the duration tables (release-resume-identity, release-pipeline-contract, ci-workflows, ci-scope-reduction, ci-test-lane, release-preflight, ci-shard-balance, ci-crash-disposition), isolated HOME: 295 pass, 0 fail.run-bun-test-batches.shassigns): the refreshed table plans 22.8 min of tests per shard, evenly. The old table planned 23.7 min per shard, yet9/11spent 27.4 min in tests (28.1 min from its first batch to its last log line) before the cancellation.tests/clients/link-ocx-child-conformance.test.tsat 48373 ms (previously absent).Checklist