Repository navigation
feat(gui): show a spinner while telemetry consent and profile actions wait - #8471
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Caution Review failedThe pull request is closed. Walkthrough
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Maintainer integration (MAINTAINERS.md): no second maintainer approval. Exact-head CI on 0bedac0: 14 checks pass; Codex review completed with no findings; CodeRabbit still pending (not a required check). GUI tests: 39 pass, new spinner tests fail without the change. |
Summary
The first-run telemetry consent popup and the Home "Public profile & rank" card gave no visible sign that a click was being handled. After Continue or Connect, the buttons only went grey; Connect also changed its text to "Connecting…". A slow or unreachable collector (the profile client waits up to 10 s) looked like a frozen dialog.
These buttons now show a spinner and
aria-busy="true"while their request is in flight:The spinner is a new
IconSpinneringui/src/icons.tsx, drawn withanimate-spin. It stays still underprefers-reduced-motion. No request or state handling changed.Screenshots: a local 2.100.0 proxy with a temporary config home, with the save request held open in the page so the pending state stays visible.
Verification
cd gui && bun ../scripts/test-with-pinned-bun.ts --isolate tests/telemetry-consent-card.test.tsx tests/telemetry-profile-card.test.tsx tests/telemetry-settings-panel.test.tsx: 39 pass, 0 fail. Two new tests hold the request open and assert the spinner andaria-busyappear, then clear once it settles. With the component changes reverted, both new tests fail (2 fail, 27 pass).cd gui && bunx tsc -b: clean.oxlinton the changed files: clean.Checklist
Summary by CodeRabbit
New Features
Bug Fixes