You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): bring layout.json and the Anthropic pool doc back under their caps - #8485
dev at 00680193cb is red on two gates, so every open pull request fails CI on its merge ref (for example #8483):
file-size ratchet (test changed / test shards): scripts/test-layout/layout.json reached 2000 lines after feat(combos): persist target cooldowns across restarts #8117 and is reported NEW_OVERSIZED. The two combo-cooldown entries feat(combos): persist target cooldowns across restarts #8117 added (combo-cooldown-persistence.test.ts → routing, server-combo-cooldown-recording.test.ts → server) move byte for byte into the combos shard scripts/test-layout/layout-combos.json. The resolved test layout is unchanged, so tests/fixtures/test-layout-expected*.json needs no edit. layout.json is now 1998 lines.
structure gate: structure/providers/anthropic-account-pool.md grew to 603 lines in fix(quota): pool-wide capacity estimate for the Anthropic account pool card #8137, over the 600-line budget. The two pooled-estimate sentences fold into the end of the preceding paragraph with their wording unchanged. The file is now 600 lines.
No source or behavior changes.
Verification
Reproduced both failures on origin/dev (00680193cb): bun run structure:check exit 1 (603 lines), and bun test tests/ci-workflows/file-size-ratchet.test.ts 1 fail (layout.json 2000 lines, NEW_OVERSIZED).
After the change: bun run structure:check passed. bun test tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts: 38 pass, 0 fail.
Checklist
Scope stays focused and avoids unrelated cleanup.
Docs or release notes were updated when needed. (doc reflow only)
Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (none touched)
Summary by CodeRabbit
Chores
Updated the organization of automated tests across test groups. No changes to product behavior are included.
Documentation
Reformatted quota-capacity documentation; the described rules remain unchanged.
…r caps
dev at 0068019 fails two gates on every pull request:
- file-size ratchet: scripts/test-layout/layout.json reached 2000 lines after
#8117 and is NEW_OVERSIZED. The two combo-cooldown entries #8117 added move
to the combos shard (layout-combos.json); the mapping is unchanged.
- structure gate: structure/providers/anthropic-account-pool.md is 603 lines
after #8137, over the 600-line budget. The pooled-estimate sentences fold
into the preceding paragraph; the text is unchanged.
No actionable comments were generated in the recent review.
Walkthrough
The test-layout configuration now lists two cooldown tests in the combo map and removes their explicit shard assignments. The quota-capacity paragraph in the provider documentation was reflowed without changing its documented rules.
Changes: Test layout mappings
Layer / File(s)
Summary
Update test shard mappings scripts/test-layout/layout-combos.json, scripts/test-layout/layout.json
The combo layout map adds the cooldown persistence and server cooldown recording tests. Their explicit shard assignments are removed.
The test layout remains unchanged; no merge-blocking risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the CI-focused changes: moving test-layout entries and reflowing the Anthropic pool document to meet file-size limits.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 0068019 and f7806ab.
Files selected for processing: 3
scripts/test-layout/layout-combos.json
scripts/test-layout/layout.json
structure/providers/anthropic-account-pool.md
Files with no reviewable changes: 1
scripts/test-layout/layout.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devat00680193cbis red on two gates, so every open pull request fails CI on its merge ref (for example #8483):test changed/ test shards):scripts/test-layout/layout.jsonreached 2000 lines after feat(combos): persist target cooldowns across restarts #8117 and is reportedNEW_OVERSIZED. The two combo-cooldown entries feat(combos): persist target cooldowns across restarts #8117 added (combo-cooldown-persistence.test.ts→routing,server-combo-cooldown-recording.test.ts→server) move byte for byte into the combos shardscripts/test-layout/layout-combos.json. The resolved test layout is unchanged, sotests/fixtures/test-layout-expected*.jsonneeds no edit.layout.jsonis now 1998 lines.structure/providers/anthropic-account-pool.mdgrew to 603 lines in fix(quota): pool-wide capacity estimate for the Anthropic account pool card #8137, over the 600-line budget. The two pooled-estimate sentences fold into the end of the preceding paragraph with their wording unchanged. The file is now 600 lines.No source or behavior changes.
Verification
origin/dev(00680193cb):bun run structure:checkexit 1 (603 lines), andbun test tests/ci-workflows/file-size-ratchet.test.ts1 fail (layout.json2000 lines,NEW_OVERSIZED).bun run structure:checkpassed.bun test tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts: 38 pass, 0 fail.Checklist
Summary by CodeRabbit