Repository navigation
fix(combo): preserve native Messages for compatible key providers - #8488
Merged
Merged
Conversation
Co-authored-by: Andrew Wang <andrewwangmail@gmail.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
7 tasks done
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
Maintainer judgment —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun test tests/claude-integration/messages-native-combo.test.ts tests/claude-integration/messages-native-combo-framing.test.ts tests/responses/protocol-envelope.test.ts— 107 pass, 0 fail.top_kand changed the cache prefix; it passed after this change. Builder also ran four Messages suites: 178 pass, 0 fail.aeed268bd0334a62289a9e6eb9f0da6d9b7a1d19. Fresh independent technical and security reviews passed on that commit; the security reviewer ran 246 focused synthetic tests.test:changed, native Windows execution and real-provider/cache-hit verification were not run. CI remains separate evidence.Checklist
Co-authored-by: Andrew Wang andrewwangmail@gmail.com