Repository navigation
fix(link): Children owned by the desktop app or a service can leave and re-link from the Home #8529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3b2017d
3bca971
69867af
d79b051
73464c7
9c20cde
95b4a51
0b90d42
666cddf
75be4bd
5389082
9a8d110
f349b28
ea24390
c2d1188
9aae913
b0bbec1
41e714c
fe77ac0
cbe8dd2
b47df93
3d26a59
10561cd
da3da8f
31d29be
f30dc5d
247c769
e5ae67c
9b2c687
7c04b61
e9ae2a5
7fd45d3
bb8e311
cff2908
d8b94c3
1469958
946a734
f90dbe8
707b92b
c4b83b6
340b067
c6673cb
b720710
fc57a28
c413808
82c011e
d6b7f5e
bbfa89e
07efff4
1c6369d
e41ce8a
521ad93
1a44872
2c7ec70
d9687a9
ec7d1f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ export function duplicateRuntimeMessage( | |
| if (pid != null && latch.observe(evidence)) { | ||
| const supervisor = evidence.kind === "desktop" ? `, ${evidence.app}` : ""; | ||
| return `OpenCodex Desktop supervises the running proxy (pid ${pid}${supervisor}, port ${port}). ` | ||
| + "Use the running proxy, or quit OpenCodex before starting it from this CLI."; | ||
| + "Use the running proxy (restart it with 'ocx restart', re-point Codex with 'ocx sync'), or quit OpenCodex before starting it from this CLI."; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Qualify the restart advice for connected Desktop clients. This message does not distinguish standalone runtimes from connected client runtimes. For a Desktop-owned client whose durable connection is current, The new instruction therefore recommends a command that cannot restart that client. Qualify
|
||
| } | ||
| return `⚠️ Proxy already running (PID ${pid ?? "unknown"}, port ${port}). Use 'ocx stop' first.`; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not recommend changing options after disconnect preparation.
In
src/client/connect.ts, Line 1118 (disconnectClient), catalog ownership is checked both before receipt creation and after preparation. If the catalog changes between those checks, this error occurs with a saved receipt whosekeepCatalogisfalse.The suggested
ocx disconnect --keep-catalogthen fails withclient_disconnect_options_changed. The saved receipt requires the original option value.Recommend
--keep-catalogonly when no disconnect receipt has committed. For an existing receipt, explain that the original operation must be recovered, or implement a safe receipt transition before offering this command. Add coverage for an ownership change after receipt creation.