[lidge-jun]

Summary

Fixes the dev CI regression from #7526 (ee8a8fc). That change added src/server/responses/advisor-question.ts, which advisor-slot.ts imports, but did not register it in RESPONSES_CORE_MODULES (tests/helpers/responses-core-source.ts), so tests/responses/responses-core-modules.test.ts › "every extracted owner is covered and remains below 2000 physical lines" fails with one unexpected received entry, advisor-question.ts (for example run 43018998801, job 130524440838, and runs 43017883207 and 43014382846).

This PR adds advisor-question.ts to the inventory directly after advisor-slot.ts, with a "Reached from advisor-slot.ts" note, following the precedent of #7357. No runtime code changes. No companion list needed updating: the test layout, file-size ratchet, structure manifest and Lab boundary guards pass unchanged.

Verification

• bun test tests/responses/responses-core-modules.test.ts on unmodified origin/dev (a0f57c3): exit 1, 9 pass / 1 fail, the diff shows only + "advisor-question.ts".
• Same file after the fix: exit 0, 10 pass / 0 fail.
• Every test importing the inventory helper (responses-core-modules, lab-passive-production-evidence, reasoning-replay-scope-source, generic-oauth-failover, responses-passthrough-transient-policy, passive-route-linker): exit 0, 113 pass / 0 fail.
• Guard files (file-size-ratchet, repo-hygiene, structure-ssot, core-lab-boundary, state-store-sweeper, test-layout, test-layout-tooling): exit 0, 158 pass / 0 fail.
• bun scripts/test.ts tests/responses: exit 0, 8030 pass / 1 skip / 0 fail.
• bun run typecheck: exit 0. bun run structure:check: exit 0. bun run privacy:scan: exit 0.
• NOT RUN: the full bun run test suite locally; only one test helper changed and the whole tests/responses directory that consumes it passes. Remaining coverage is left to CI.

Prepared by claude-opus-5-5 in the Codex harness (GOAT).

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed. (None needed: test inventory only.)
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (No runtime, auth or logging change.)

Summary by CodeRabbit

• Tests
  • Updated test coverage to include advisor question-only consultation text handling.

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-11T12:50:36.481001Z	326047e	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The test source inventory now includes advisor-question.ts and identifies its relationship to advisor-slot.ts.

Changes: Responses core source inventory

Layer / File(s)	Summary
Add advisor question source tests/helpers/responses-core-source.ts	The source inventory adds advisor-question.ts and notes that advisor-slot.ts reaches it. The comment describes its role in clipping opt-in question-only consultation text.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested labels: bug

Merge Risk: Minimal · up to 32604

This updates the test inventory to include a module that was missing, and it does not affect runtime behavior. Merge risk is minimal.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely identifies the main change: registering advisor-question.ts in the responses core module inventory.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: lidge-jun/opencodex
• Branch: test/register-advisor-question
• File: .coderabbit.yaml
• Commit: 326047e
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 9e24bd62-edc6-45eb-a347-b545e1b60938

Commits

Reviewing files that changed from the base of the PR and between a0f57c3 and 326047e.

Files selected for processing: 1

• tests/helpers/responses-core-source.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

[lidge-jun]

Maintainer judgment

Value: fixes the red dev batch. Batch run 43020802967 at fb2e3db897 failed on macOS 1/4, Linux test 5/5 and Windows 3/11. All three failed one test: Responses core module boundaries > every extracted owner is covered and remains below 2000 physical lines. #7526 added src/server/responses/advisor-question.ts but never listed it in RESPONSES_CORE_MODULES.

Change: a test-only, 2-line edit to tests/helpers/responses-core-source.ts that adds the missing module to the list. It changes no runtime code, so it has no UX change and cannot regress existing users.

Review (coordinator, not the PR author), exact head 326047e6dc: the added entry is exactly the one unexpected item the failing assertion reported. advisor-question.ts is imported by advisor-slot.ts, which is already listed. Since this head, dev has taken #8546, #8551 and #8555, and none of them touches src/server/responses/ or the core list.

CI on the exact head: 16 passed, 15 skipped, 0 failed.

Windows: test-only change; the next dev batch is the check.