You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(service): scope unknown probes during launchd recovery - #8572
Repair guidance currently promises no further eviction whenever a launchd probe becomes unknown after bootstrap. That is accurate for the probe immediately after bootstrap. For an unchanged definition, however, a later recovery kickstart can succeed and its following unknown probe can still lead to another eviction. Scope the guarantee to the immediate probe and describe the recovery case in English, all seven translations and the architecture contract.
Addresses the remaining documentation finding from the now-merged #8456: #8456 (comment). This change documents the current installLaunchd control flow; it does not alter service recovery, health probe deadlines or credential locking.
Verification
Documentation-only validation at 227366c74f91237c4c4a00d6df8a56b1cab73910 after merging dev46a3db0d755797ff2530da6bed2147268d64fef2:
The personal wording patch has the same stable patch ID before and after the base refresh. The relevant installLaunchd control flow is unchanged: immediate post-bootstrap unknown skips recovery; an unchanged-definition recovery kickstart can still be followed by unknown and another eviction/bootstrap.
bun run typecheck: no errors in 2,459 files. bun run privacy:scan, bun run structure:check and git diff --check --cached origin/dev (before the merge commit): pass.
cd docs-site && bun install --frozen-lockfile && bun run build: pass; 665 pages and 96,234 internal links checked.
Runtime tests were not repeated for this documentation-only PR, and no prior runtime run is presented as current-head validation. No manual full-CI workflow was dispatched. Fresh automated review and upstream CI are separate from these scoped checks.
Checklist
Scope stays focused and avoids unrelated cleanup.
Docs or release notes were updated when needed.
Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (documentation only).
Review readiness checklist
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Ready for review based on the scoped checks above. Fresh automated review and upstream CI completion are separate requirements.
Summary by CodeRabbit
Documentation
Clarified launchd repair behavior when status checks cannot read state immediately after bootstrap, including the outcomes for accepted and rejected bootstraps.
Documented that an unreadable status check after a successful recovery kickstart may lead to another job removal.
Updated the guidance across supported language versions.
all PR quality gates passed; the review readiness checklist is complete.
Review readiness checklist
✅ Required local validation passed; commands, results, and any full-suite exception are documented.
✅ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
✅ I resolved all correct Codex and CodeRabbit findings.
✅ My PR is ready for review.
✅ 4/4 boxes ticked.
This pull request has been marked Ready for Review.
The review-ready label marks this PR as ready; review automation runs independently.
Maintainers notified: @lidge-jun@Ingwannu
No actionable comments were generated in the recent review.
Walkthrough
The launchd repair documentation now specifies the outcomes of an unreadable status probe immediately after bootstrap. It also describes possible job removal after a successful recovery kickstart when a later probe cannot read state.
The documentation limits the no-further-action rule to an unreadable probe immediately after bootstrap. It describes accepted and rejected bootstrap outcomes, and notes that a later unreadable probe after a successful recovery kickstart for an unchanged definition may lead to another job removal.
lidge-jun/opencodex#8456: Changes launchd repair behavior and documentation for unreadable post-bootstrap probes; this PR revises the documented conditions.
lidge-jun/opencodex#8385: Changes launchd retry behavior during teardown, which relates to the bootstrap outcomes described here.
Merge Risk: Minimal · up to 6b529
This documentation-only change clarifies launchd repair probe behavior. It does not alter runtime behavior, and no merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title accurately and concisely describes the documentation change: it scopes unknown probes during launchd recovery. This matches the main change across the English, translated, and architecture d…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title accurately and concisely describes the documentation change: it scopes unknown probes during launchd recovery. This matches the main change across the English, translated, and architecture documentation.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair guidance currently promises no further eviction whenever a launchd probe becomes unknown after bootstrap. That is accurate for the probe immediately after bootstrap. For an unchanged definition, however, a later recovery kickstart can succeed and its following unknown probe can still lead to another eviction. Scope the guarantee to the immediate probe and describe the recovery case in English, all seven translations and the architecture contract.
Addresses the remaining documentation finding from the now-merged #8456: #8456 (comment). This change documents the current
installLaunchdcontrol flow; it does not alter service recovery, health probe deadlines or credential locking.Verification
Documentation-only validation at
227366c74f91237c4c4a00d6df8a56b1cab73910after mergingdev46a3db0d755797ff2530da6bed2147268d64fef2:installLaunchdcontrol flow is unchanged: immediate post-bootstrap unknown skips recovery; an unchanged-definition recovery kickstart can still be followed by unknown and another eviction/bootstrap.bun run typecheck: no errors in 2,459 files.bun run privacy:scan,bun run structure:checkandgit diff --check --cached origin/dev(before the merge commit): pass.cd docs-site && bun install --frozen-lockfile && bun run build: pass; 665 pages and 96,234 internal links checked.Checklist
Review readiness checklist
Ready for review based on the scoped checks above. Fresh automated review and upstream CI completion are separate requirements.
Summary by CodeRabbit