Conversation
|
Hey! This is your new endpoint: https://6abae1ed.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://91d12bb6.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://39a0d204.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://e8ee81b0.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://bcf5d7b5.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://798c4975.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://64be43dc.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://cf49c6f2.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://6f861436.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://bd36c82b.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://84e11063.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://8aeffe7d.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://a2e01394.widget-featactivi.pages.dev |
| import { useGetScrollableContainer } from '../hooks/useScrollableContainer.js' | ||
| import { useGetScrollableContainer } from '../../hooks/useScrollableContainer.js' | ||
|
|
||
| export const modalProps: { sx: { position: string; overflow: string } } = { |
There was a problem hiding this comment.
This isn't being edited here in this PR, but "modal props" and "dialog props" look confusing. Is it because MUI already has DialogProps?
There was a problem hiding this comment.
probably it's worth renaming eventually, "dialog props" seem to be part of "modal props".
now we have 2 types of modals/dialogs: centered and bottom ones
There was a problem hiding this comment.
Okay. We can place a todo here for the future then.
| )(({ theme }) => ({ | ||
| '& .MuiBadge-badge': { | ||
| padding: 0, | ||
| minWidth: 'unset', |
There was a problem hiding this comment.
It's good to double-check any time unset creeps in, because this doesn't mean "reset" the value.
It means:
If this property is inherited, revert to the inherited value. Otherwise, set it to the initial (browser default) value.
Browser default here is auto. So min-width doesn't inherit it's value unless we explicitly set it to inherit. You should be good here, but these nuances are important to pay attention to.
There was a problem hiding this comment.
alright, I'm putting 16px to min-width, not intending any resizing on it.
| } | ||
|
|
||
| const ExecutionTimer = ({ | ||
| export const ExecutionTimerText = ({ |
There was a problem hiding this comment.
Is it a timer, or maybe a countdown instead? Timer is indefinite, while countdown has an expiry.
There was a problem hiding this comment.
Well, countdowns are "Timers" on my iPhone 😄
| }: ContextMenuProps): JSX.Element => { | ||
| const { t } = useTranslation() | ||
| const menuId = useId() | ||
| const [anchorEl, setAnchorEl] = useState<HTMLElement | null>(null) |
There was a problem hiding this comment.
see: CSS anchors. This may simplify the setup.
There was a problem hiding this comment.
Interesting. MUI's Menu needs anchorEl though. Plus browser support on Safari? Too new 😄
| height: 24, | ||
| display: 'grid', | ||
| placeItems: 'center', | ||
| flexShrink: 0, |
There was a problem hiding this comment.
this property will only work with flexbox parents. Is it intentional?
There was a problem hiding this comment.
The parent is flex, yes.
|
Hey! This is your new endpoint: https://99f6a5a6.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://4eccb34c.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://0305a370.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://576ff916.widget-featactivi.pages.dev |
|
Hey! This is your new endpoint: https://565ee212.widget-featactivi.pages.dev |
3 participants
Which Linear task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-320/merge-active-transactions-and-transaction-history
Why was it implemented this way?
The separate Active Transactions and Transaction History pages have been merged into a single Activities page. This unified view renders all transaction states — pending/failed local routes and completed API history — in one chronologically sorted list.
Considerations:
Visual showcase (Screenshots or Videos)
Screen.Recording.2026-04-08.at.09.58.49.mov
Checklist before requesting a review