Bump rust-lightning to 49912057895ddfbd69d503de67c80d5576c09953#833
Closed
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Bump rust-lightning to 49912057895ddfbd69d503de67c80d5576c09953#833joostjager wants to merge 1 commit intolightningdevkit:mainfrom
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Mar 19, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Some of these changes look fine, but the PaymentForwarded changes in particular are part of #825 and should be properly fixed there. If you want to make progress I propose to keep this commit as a first DROPME commit in the deferred write PR, and then we can rebase there once the rest of the changes landed.
Contributor
Author
|
Ok, will do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.