feat(delegate): highlight name in delete confirmations (closes #37)#40
Merged
fdaugan merged 1 commit intoMay 27, 2026
Merged
Conversation
Both delete dialogs of the Delegate screen now render the receiver name in <strong class="text-error"> via the LigojConfirmDialog default slot, matching the pattern of PR #39 for User / Company / Group / GroupMembers: - DelegateListView: the trash-icon dialog from each row (inline <v-dialog> converted to LigojConfirmDialog + slot) - DelegateEditDialog: the "Delete" button inside the edit popup (existing LigojConfirmDialog with :message= switched to the slot) The host's monolithic delegate.deleteConfirm key stays intact; two plugin-local fragments (delegate.deleteConfirmBefore/After) are added in FR + EN to wrap the name. Mini-commit deliberately split from PR #39 because the Delegate dialog files did not exist on feature/vuejs until PR #35 was merged. Closes #37
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Issue #37 — sur l'écran Délégué, les deux dialogs de suppression affichaient le nom du destinataire en texte normal, alors que toutes les autres confirmations sensibles (User / Company / Group / GroupMembers, livrées par PR #39) le rendent en gras+rouge.
Mini-commit volontairement séparé de PR #39 : les fichiers
DelegateEditDialog.vue/DelegateListView.vue(créés par PR #35) n'existaient pas encore surfeature/vuejsau moment du travail sur PR #39.Changements
Vues
DelegateListView.vue: la dialog ouverte par l'icône 🗑️ de chaque ligne était un<v-dialog>inline avec:message=t('delegate.deleteConfirm', { name }). Convertie enLigojConfirmDialogavec slot par défaut +<strong class="text-error">{{ name }}</strong>. Ajout de l'importLigojConfirmDialogdepuis@ligoj/host.DelegateEditDialog.vue: la dialog ouverte par le bouton "Supprimer" intra-popup utilisait déjàLigojConfirmDialogmais via la prop:message=. Bascule sur le slot par défaut.i18n (plugin-id, FR + EN)
delegate.deleteConfirmBefore/delegate.deleteConfirmAfter— fragments encadrant le nom du destinataire."...la délégation pour {name} ?"→ splitté avant/après le nom).delegate.deleteConfirmn'est pas touchée (out of scope) — elle reste disponible pour tout autre consumer.Out of scope
LigojConfirmDialogcôté core : pas modifié, on utilise son slot par défaut existant.bulkDeleteDialogdeDelegateListView(action collective sans nom à exhiber) : laissé tel quel — cohérent avec le choix fait pour le bulk delete des Users (PR feat(user): polish list + edit dialog + harmonized confirmations (D1+D2+D4) #39).Test plan
npm run build→ 28 modules, 117 kB JSvitest run→ 14/14mvn install -DskipTests→ BUILD SUCCESSCloses #37