feat(ui): add entity icons to dialog titles#52
Merged
Conversation
Prepend each dialog title with an icon representing the entity it concerns, generalizing the pattern already used by the group/company detail dialogs: - raw v-dialog titles (container-scope, delete and bulk-delete confirms) get a leading v-icon; - LigojConfirmDialog call sites pass the new :icon prop; - unsaved-changes guards use a save-alert icon. Icons reuse the shared TYPE_ICONS map (extended with SCOPE and DELEGATE). Closes #51
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Issue #51 asks to prepend every dialog title with an icon representing the edited entity, and to generalize the concept across the application. Some dialogs (group/company details, group members) already followed this pattern; this PR brings the rest in line.
Change
v-dialogtitles (container-scope edit/delete, group/company/delegate delete and bulk-delete confirmations, delegate edit) get a leadingv-icon.LigojConfirmDialogcall sites pass the new:iconprop (user delete/bulk/action, group/company/member removal, delegate delete).mdi-content-save-alerticon.TYPE_ICONSmap, extended withSCOPEandDELEGATE.Dependency
The
LigojConfirmDialog:iconprop is added in ligoj/ligoj#104. Unknown attributes fall through harmlessly until that lands, so this PR is safe to merge independently, but the confirm-dialog icons only render once #104 is deployed.Test plan
Closes #51