TPT-4527: Implemented changes for SLADE and CLEO projects#665
Open
ezilber-akamai wants to merge 2 commits intolinode:proj/slade-cleofrom
Open
TPT-4527: Implemented changes for SLADE and CLEO projects#665ezilber-akamai wants to merge 2 commits intolinode:proj/slade-cleofrom
ezilber-akamai wants to merge 2 commits intolinode:proj/slade-cleofrom
Conversation
2acd3aa to
a29b93a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Linode create/rebuild/disk-create flows to support SLADE/CLEO requirements by adding kernel and boot_size to instance creation and changing how root_pass is handled when SSH keys are provided.
Changes:
- Add
kernelandboot_sizefields toLinodeGroup.instance_create. - Change
instance_create,Instance.rebuild, andInstance.disk_createto require at least one ofroot_passorauthorized_keys, and stop returning generated passwords. - Update unit tests to pass explicit
root_passand to assert the new return values.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
linode_api4/groups/linode.py |
Updates instance_create signature, validation, request payload, and return type; adds kernel/boot_size. |
linode_api4/objects/linode.py |
Updates disk_create and rebuild credential validation and return behavior. |
test/unit/objects/linode_test.py |
Updates object-level unit tests for rebuild and disk_create new return values and request bodies. |
test/unit/linode_client_test.py |
Updates client unit tests for instance_create to include explicit root_pass and assert payload. |
test/unit/groups/linode_test.py |
Updates/extends group-level unit tests, including new coverage for kernel/boot_size. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a29b93a to
71544fc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added new kernel and boot_size fields to Linode Create options. Also made
root_passoptional whenimageis provided (ifauthorized_keysis provided instead) for Linode creation and rebulding, and Linode Disk creation.✔️ How to Test
make test-unit