python-libnvme: drop 1.x backward-compatibility shims#3205
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Mar 30, 2026
Merged
python-libnvme: drop 1.x backward-compatibility shims#3205igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
Remove the deprecated method wrappers `discovery_ctrl_set()` and `persistent_set()` on `ctrl`, and the module-level aliases `NVME_LOG_LID_DISCOVER` and `root` that existed for compatibility with libnvme 1.x code. Callers should use the property setters (`ctrl.discovery_ctrl`, `ctrl.persistent`) and the canonical names (`NVME_LOG_LID_DISCOVERY`, `global_ctx`) directly. Add a new Python test module (test-objects.py) covering object creation and property access, iterator correctness, boolean flag get/set, and error handling for disconnected controllers, replacing the removed deprecation-warning tests. The new tests allowed finding and fixing a pre-existing bug in nvme.i where a NULL returned by nvme_read_hostnqn() or nvme_read_hostid() was not being handled and would cause a crash. Signed-off-by: Martin Belanger <martin.belanger@dell.com> cac
martin-belanger
force-pushed
the
python-cleanup
branch
from
6d6fc0a to
234d30e
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated method wrappers
discovery_ctrl_set()andpersistent_set()onctrl, and the module-level aliasesNVME_LOG_LID_DISCOVERandrootthat existed for compatibility with libnvme 1.x code. Callers should use the property setters (ctrl.discovery_ctrl,ctrl.persistent) and the canonical names (NVME_LOG_LID_DISCOVERY,global_ctx) directly.Add a new Python test module (
test-objects.py) covering object creation and property access, iterator correctness, boolean flag get/set, and error handling for disconnected controllers, replacing the removed deprecation-warning tests.The new tests allowed finding and fixing a pre-existing bug in
nvme.iwhere aNULLreturned bynvme_read_hostnqn()ornvme_read_hostid()was not being handled and would cause a crash.