Skip to content

test: check invalid inputs for correct error message #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richm merged 1 commit into from
Oct 22, 2026
Merged

test: check invalid inputs for correct error message #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions tests/tests_invalid_input.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
__ssh_test_backup_files:
- /etc/ssh/ssh_config.d/00-ansible.conf
- /etc/ssh/ssh_config
__invalid_input_failure_messages: >-
{{ ([ansible_failed_result.msg | default('') | string,
ansible_failed_result.msg.msg | default('') | string]
+ (ansible_failed_result.results | default([])
| map(attribute='msg') | map('default', '') | list))
| join(' ') }}
tasks:
- name: Backup configuration files
ansible.builtin.include_tasks: tasks/backup.yml
Expand Down Expand Up @@ -45,6 +51,9 @@
- name: Mark invalid ssh_backup rejected
ansible.builtin.set_fact:
__invalid_input_backup_type_failed: true
when: >-
"argument 'ssh_backup'" in __invalid_input_failure_messages
and 'convert to bool' in __invalid_input_failure_messages

- name: Assert invalid ssh_backup type failed validation
ansible.builtin.assert:
Expand All @@ -65,6 +74,10 @@
- name: Mark invalid ssh_additional_packages rejected
ansible.builtin.set_fact:
__invalid_input_additional_packages_type_failed: true
when: >-
"argument 'ssh_additional_packages'"
in __invalid_input_failure_messages and
'convert to list' in __invalid_input_failure_messages

- name: Assert invalid ssh_additional_packages type failed validation
ansible.builtin.assert:
Expand All @@ -88,8 +101,10 @@
ansible.builtin.set_fact:
__invalid_input_skip_defaults_value_failed: true
when: >-
'ssh_skip_defaults must be' in
(ansible_failed_result | default({}) | to_json)
"ssh_skip_defaults must be 'auto' or a boolean"
in __invalid_input_failure_messages and
('got str' in __invalid_input_failure_messages or
'got AnsibleUnicode' in __invalid_input_failure_messages)

- name: Assert ssh_skip_defaults invalid value failed validation
ansible.builtin.assert:
Expand All @@ -112,8 +127,8 @@
ansible.builtin.set_fact:
__invalid_input_ssh_list_failed: true
when: >-
'ssh must be a dict' in
(ansible_failed_result | default({}) | to_json)
'ssh must be a dict or an empty list, got list'
in __invalid_input_failure_messages

- name: Assert ssh as non-empty list failed validation
ansible.builtin.assert:
Expand All @@ -134,8 +149,10 @@
ansible.builtin.set_fact:
__invalid_input_ssh_string_failed: true
when: >-
'ssh must be a dict' in
(ansible_failed_result | default({}) | to_json)
('ssh must be a dict or an empty list, got str'
in __invalid_input_failure_messages or
'ssh must be a dict or an empty list, got AnsibleUnicode'
in __invalid_input_failure_messages)

- name: Assert ssh as string failed validation
ansible.builtin.assert:
Expand All @@ -156,8 +173,8 @@
ansible.builtin.set_fact:
__invalid_input_config_mode_bool_failed: true
when: >-
'ssh_config_mode must be' in
(ansible_failed_result | default({}) | to_json)
'ssh_config_mode must be a string or integer, got bool'
in __invalid_input_failure_messages

- name: Assert ssh_config_mode as boolean failed validation
ansible.builtin.assert:
Expand All @@ -178,8 +195,10 @@
ansible.builtin.set_fact:
__invalid_input_reboot_ok_string_failed: true
when: >-
'ssh_transactional_update_reboot_ok must be' in
(ansible_failed_result | default({}) | to_json)
'ssh_transactional_update_reboot_ok must be null or a boolean'
in __invalid_input_failure_messages and
('got str' in __invalid_input_failure_messages or
'got AnsibleUnicode' in __invalid_input_failure_messages)

- name: Assert ssh_transactional_update_reboot_ok as string failed validation
ansible.builtin.assert:
Expand Down
Loading