Repository navigation
Revert the unified train CLI pushed directly to main - #173
Merged
Merged
Conversation
These seven commits (6ac8bf0..75cf26a) landed on main without review because the feature branch tracked origin/main and was pushed there. Revert them so the change can come back through a reviewed PR. Reverted: 75cf26a refactor: unify training command documentation and remove legacy commands 15161dd feat: add option to export trained model to ONNX in ModelTrainerTorchMLP f9f737a refactor: unify CLI commands to use 'train' instead of 'torchtrain' and 'jaxtrain' 8cbbcc0 Add new train module 58c6ecb test: update CLI tests to use unified train command 6490086 refactor: remove legacy training CLI for JAX and PyTorch 6ac8bf0 Update pyproject.toml Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change restoring separate backend-specific training commands.
No open issues 🎉
What changed in this PR
Reverts the unreviewed unified training CLI, restoring separate jaxtrain and torchtrain commands ahead of a separately reviewed feature PR.
Changes:
- Restores backend-specific training CLIs and prior PyTorch ONNX export behavior.
- Reverts package metadata to version
0.10.0and restores CLI tests. - Updates documentation and comments to use the restored command names.
| File | Description |
|---|---|
tests/test_jax_mlp.py |
Restores jaxtrain wording in comments only. |
tests/derive/test_roundtrip.py |
Calls the restored torchtrain function with explicit options. |
tests/derive/test_corpus.py |
Restores jaxtrain wording in a comment only. |
tests/cli/test_cli_entry_points.py |
Restores separate subprocess smoke tests for both CLIs. |
src/lanfactory/trainers/torch_mlp.py |
Removes the export toggle; always exports ONNX when saving outputs. |
src/lanfactory/trainers/jax_mlp.py |
Restores torchtrain wording in a comment only. |
src/lanfactory/onnx/jax_export.py |
Restores jaxtrain terminology in docstrings only. |
src/lanfactory/cli/torch_train.py |
Restores the standalone PyTorch training CLI. |
src/lanfactory/cli/jax_train.py |
Restores the JAX-specific training implementation. |
src/lanfactory/cli/derive_aux.py |
Updates docstrings to name both training commands. |
src/lanfactory/__init__.py |
Reverts the package version to 0.10.0. |
pyproject.toml |
Restores version, console entry points, and coverage exclusions. |
docs/using_mlflow.md |
Restores backend-specific commands in tracking examples. |
docs/network_types.md |
Restores training command names and examples. |
docs/api/cli.md |
Restores separate training command references and option tables. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unified
train --backend {torch,jax}CLI landed onmainas seven unreviewed commits (6ac8bf0..75cf26a): the feature branch was created fromorigin/mainand tracked it, so the push went straight tomain.This reverts all seven in a single commit. The resulting tree is identical to
a6cdd9d(the merge of #171), the last reviewed state ofmain, sojaxtrain/torchtrainare restored exactly as they were.The feature itself will come back as a separate PR for review. Because these commits will now be reverted on
main, that PR has to be built on top of this revert (re-applying the change), not by re-merging the original commits.🤖 Generated with Claude Code