feat: configure CI environment to talk to LocalStack#62
Conversation
93cdb40 to
d88b62f
Compare
|
The ephemeral instance for the application preview has been shut down |
c4a678e to
1518c68
Compare
1518c68 to
f40f241
Compare
steffyP
left a comment
There was a problem hiding this comment.
Thanks a lot for the addition @simonrw 🙏
It would be great if we could add this to the README as well (at least before the next release).
Personally I think this is good to merge :)
I am not sure what the upcoming release strategy is though (I only helped out with a cleanup initiative).
/cc @dominikschubert - could you maybe assign the PR to the new repo owner(s)?
dominikschubert
left a comment
There was a problem hiding this comment.
Great idea overall! Looking at potential hybrid scenarios, I'm just not sure we should make this the default, at least for now. Adding it first as an option would also be less of a breaking change (even though we're still on 0.x and not bound by semver).
Motivation
When using the
setup-localstackaction, the user currently has to setAWS_ENDPOINT_URLto target LocalStack. This is inconvenient - if we are providing a helper action to configure LocalStack then we should set the CI environment as well.Changes
AWS_ENDPOINT_URLby default tohttp://localhost.localstack.cloud:4566Thanks @dfangl for the idea!