-
Notifications
You must be signed in to change notification settings - Fork 12
Use the LocalStack pro image by default #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Changelog | ||
|
|
||
| ## [0.3.0] | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| - **`use-pro` now defaults to `true`.** The action will use the `localstack/localstack-pro` image by default. Workflows that relied on the community image without setting `use-pro` will now get the Pro image, which requires a `LOCALSTACK_AUTH_TOKEN`. Set `use-pro: 'false'` explicitly if you need the community image. For newer versions of LocalStack these images are equivalent. | ||
|
|
||
| ### Deprecated | ||
|
|
||
| - **`use-pro` input will be removed in a future release as we are consolidating our docker images**. | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,9 +11,10 @@ inputs: | |
| required: true | ||
| default: 'true' | ||
| use-pro: | ||
| description: 'Whether to use LocalStack Pro (requires a valid CI Auth Token)' | ||
| description: 'Deprecated. Whether to use LocalStack Pro (requires a valid CI Auth Token)' | ||
| required: false | ||
| default: 'false' | ||
| default: 'true' | ||
| deprecationMessage: 'use-pro is deprecated and will be removed in a future release. The pro image is now the default.' | ||
| configuration: | ||
| description: 'Configuration variables to use for LocalStack' | ||
| required: false | ||
|
|
@@ -62,7 +63,10 @@ runs: | |
| - name: Start LocalStack | ||
| run: | | ||
| if [ "$USE_PRO" = true ]; then | ||
| if [ "x$LOCALSTACK_AUTH_TOKEN" = "x" -o "x$LOCALSTACK_API_KEY" = "x" ]; then | ||
| if [ "x$LOCALSTACK_API_KEY" != "x" ]; then | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thought (non-blocking): This is an interesting way of testing if a variable is empty or not (but I se this was already the case before, so totally out of scope). 😅
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As you said, I mostly just kept it to stay close to the current version, especially since I expect a more fundamental rewrite here anyway. 👍 |
||
| echo "WARNING: LOCALSTACK_API_KEY is deprecated, please use LOCALSTACK_AUTH_TOKEN instead." | ||
| fi | ||
| if [ "x$LOCALSTACK_AUTH_TOKEN" = "x" -a "x$LOCALSTACK_API_KEY" = "x" ]; then | ||
| echo "WARNING: LocalStack Auth Token not detected, please verify your configuration..." | ||
| fi | ||
| CONFIGURATION="DNS_ADDRESS=127.0.0.1 ${CONFIGURATION}" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: TIL GitHub actions have an explicit declaration of deprecation for variables 🤩