Repository navigation
docs: include Journal execution guide in Dune odoc output - #155
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the missing normal-project documentation output for the execution guide introduced in #154.
app/spec/journal_execution_flow.mliunchanged as the sole body source.logseq_journalpackage.The final diff contains only
app/spec/dune,app/spec/index.mld, andapp/spec/README.md. No documentation tests, runtime modules, libraries, exported APIs, or source-boundary changes are added.Validation
Validated source tree
d21b35e171c38d5a23667bf931838362691711b3in the existing lockedlogseq-journal-luiswitch:dune build @all app/native_embed.exe.o @doc -j 3: passed.dune runtest --force -j 3: existing suite passed; 1,339 Alcotest cases across 22 suites, 24 positive/31 negative coordination contracts, and clean source-boundary checks.test/tree and the source.mliare unchanged from the base.After
dune build @doc, open_build/default/_doc/_html/logseq_journal/index.html; its guide link resolves tojournal_execution_flow.html.Existing issues and scope
spec-dev-tool check --allstill reports these six pre-existing decision-document format failures. Its complete output is byte-for-byte identical on the base and this change:docs/agent-guide/001-fixed-timeline-hosts.mddocs/agent-guide/implemented/architecture/2026-10-19-local-only-startup-network-gate.mddocs/agent-guide/implemented/bugfix/2026-10-06-timeline-soft-scroll-edge.mddocs/agent-guide/implemented/bugfix/2026-10-09-favorites-native-soft-header.mddocs/agent-guide/implemented/bugfix/2026-10-20-encrypted-graph-raw-assets.mddocs/agent-guide/implemented/feature/2026-09-28-bottom-lui-capsules.mdExisting odoc ambiguous-reference warnings are unchanged. No Apple packaging or GUI acceptance was run for this documentation-only integration.