Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cached Lambda RTC launches showed overlapping catalog fetches.
request_catalog_reconciliationshares an in-flightFetch_catalogonly within the exact account/presentation/lifecycle scope; explicit refresh remains independent. Coalesced newer authentication survives token-flight revocation through one structured-cancellation retry; ordinary authentication errors remain visible.Add default-off startup spans through SwiftUI/App construction, native services, local attach/restore and feed publications. Capture
mach_absolute_time()at the first source statement before diagnostic flag/Foundation initialization, preservingmain_enterand emitting the savedmain_rawtimestamp afterward. Logging remains off by default, with one unconditional clock read. The runbook distinguishes saved timestamps, process birth, exec, callbacks, displayed frames and overlapping spans.In
paginate_children, retain structural membership/digest selection for all candidates, but hydrate only selected children through the existinglogical_block_atpath. Lazily create a non-indexed hydration cache rather than collecting every child's full datoms and rebuilding the global ident index per preview; overlay/tombstone/revision/cursor semantics remain intact.Final-input validation
At
0a684de472337353722de58813c8ab0c7508d63d, fulldune build @all app/native_embed.exe.o,dune runtest --force, maintained Release Apple build and diff hygiene pass. Final CI (build-and-test,WIP) is green. Independent read-only reviews found no confirmed issue in retained raw-entry/DB changes; final database SHA256 matches reviewed0e39bfa. The pure reducer regression covers catalog coalescing, completion, account/lifecycle boundaries and bounded cancellation retry.spec-dev-toolreports a clean source boundary and the same six format errors in unchanged decision documents.The smaller-first-root-prefix experiment failed existing visibility/native-mount regressions and was reverted with a new commit; no tests were changed to accept it. Final code retains the existing first-prefix semantics.
Real cached-graph controls: no demonstrated latency improvement
Three baseline launches (
eefb2d6, native8989f98) followed by three final launches (0a684de, native0e39bfa) retained the same real Lambda RTC account, cached graph and Keychain on the iPhone 17 / iOS 27.0 Simulator. Baseline and final have the same Swift entry; the only production OCaml difference is selected-child hydration. Ordinary installs preserved identity/content; each trial verified old-process absence and a new PID. Numerical controls used no screenshot polling, sampling or concurrent builds; recording was separate. The sequential, nonrandomized design does not support causal speedup/regression claims.main_raw, rangemain_raw→ oldmain_enter, rangeFirst-feed timestamps are scan-to-publication, not launch-to-visible-pixels; the UI accepts
complete=false. No causal first-frame or feed speedup is established. Raw-entry measurements show that diagnostic initialization cannot explain the earlier 1.266–1.319 s birth→main-marker interval. The remaining window still lacks a runtime owner; it is not a measured dyld-function duration or proof of OCaml startup cost. Static fixup/native-symbol counts are leads, not milliseconds. Earlier xctrace and DYLD statistics attempts produced no usable attribution. Three initial observer-configuration failures without process-birth results were excluded explicitly, not selected by performance.Default-off smoke captured 113 console lines with zero startup/feed/unlock diagnostics. Separate real-graph UI verification passed cached content recovery, Current / Ready / Open, empty outbox and responsive Options. The standard recording verifies old PID 13591 absent before new PID 13958 restored content and returned from Options. The same-build Diagnostics screenshot is from the preceding PID 13591 verification, not a fresh Diagnostics assertion for PID 13958.
Final annotated process-cold UI recording
Final installed executable SHA256:
ee0228f2d4ec51832238f2eac87d4ba80b7a18d7e7adab99304c3b323a41f72e, matching the final manifest. Experimental host-restamp remainscross_abi_validated=false. No cache/Keychain reset, graph switch, sign-out, repair or fixture substituted for these controls. Precise exec→main, first pixels, individual loader costs, real-device performance/ABI, offline/reboot and forced cancellation/cross-account abnormal UI remain untested.Earlier catalog acceptance at
8989f98observed one successful catalog request per cached launch (maximum in-flight 1, baseline 2/1/2), without a causal first-frame speedup claim. The earlier graph-close CI failure remains unexplained; current green CI does not establish that failure as flaky or pre-existing.Open in Devin Desktop: https://app.devin.ai/desktop/session/7a5eed6555b64cd682e8abd3905c930f?variant=devin
Requested by: @RCmerci
🟢 Devin Review found nothing to fix · View findings · Follow Devin's work