Repository navigation
fix: wait for initial timeline data and native layout - #159
Merged
Merged
Conversation
RCmerci
marked this pull request as ready for review
November 10, 2026 06:08
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the cold-start loading presentation until the bounded initial Timeline feed is complete and the native list has completed its first valid viewport layout. Previously, the first incremental
complete=falsefeed could reveal the Timeline while rows and child previews were still arriving.complete=true; keep already-presented content visible during later refreshes.The gate waits for the bounded initial feed, not the full graph, later pagination, or remote media downloads.
Validation
Validated the exact five-file patch in commit
ee6341cb39daf91c3d400367d604b5e26e294760(patch SHA256fdaa02e9833466ecb2e1a6ede459c27f50b2bc23dbfe1ed005149313733dcaf5). Its parent is7b180041ae829f84f0452b7684f167e829909206; subsequent main changes at publication are documentation-only and do not overlap this patch.opam exec --switch logseq-journal-lui -- dune build @all app/native_embed.exe.o: passed.opam exec --switch logseq-journal-lui -- dune runtest --force: passed.python3 tool/test_graph_name.py, andgit diff --check: passed.Boundaries and remaining validation
cross_abi_validated=false. Full iOS runtime ABI, physical-device behavior, and a real-account graph have not been validated.spec-dev-tool check --allcould not run because the executable is unavailable. No spec or Dune files changed.