Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move every OCaml bridge entry onto one process-lifetime serial thread. Worker wakeups now advance application state/feed planning without waiting for SwiftUI work; the LUI backend and platform facade remain on MainActor.
Matched Release Simulator evidence
32 process-cold launches, 16 balanced adjacent pairs, same retained account/graph/cache/Keychain. Both variants import the identical native object and use the same LUI pin, Release configuration, SDK and toolchain. No profiler or recording in this cohort.
main_raw→ first feed receiptThe primary feed-receipt improvement is 17.21%; all 16 pairs improve (paired median 18.06%). This is not a 17% visible-first-screen claim. Pre-main time does not improve. An earlier 32-run screen used a different native object and is excluded from attribution.
A separate 16-launch video-on ABBA cohort estimates useful sampled pixels at 2552.2 → 2452.9 ms; paired median 3.23%, conditional bootstrap 95% 1.33–4.67%. Capture-clock and uncalibrated framebuffer delays prevent a stable ≥3% visible-latency claim. Real cached-content cold start, read-only navigation, scrolling, Options/Diagnostics and two foreground returns passed; private recordings are not published.
Validation and limits
CI is green on the unchanged final head. The controlled rerun of run 42821387763, build-and-test job 129866433950, passed the complete gate, including the previously failing durable-delete case. The earlier deletion failure did not recur; its root cause remains unproven and is not classified as preexisting/flaky or fixed by retry. No deletion assertion, deadline or production logic changed. The scoped picker-fixture repair also passes; its forced hidden-menu probe establishes a selector ambiguity, not historical CI target selection. Existing local exact base/head controls and the original failed CI evidence are retained.
Final head:
ef7f7916b18725b822bdba7eee9e82941e8c9770; all 35 production Swift input hashes match the measured candidate (86e587e). The two follow-ups change a test-only isolation annotation and scope the existing picker account-menu lookups; production bytes are unchanged. Fulldune build @all app/native_embed.exe.o,dune runtest --force, 13 startup cases, 16 failure cases, graph-name feedback, native event ABI tests and diff hygiene pass locally. The initial CI caught the overlooked failure-harness stub annotation; its complete original matrix now runs unchanged. Independent read-only review of the production diff found no remaining confirmed blocker. New production lines have zero formatter diagnostics; pre-existing whole-file style diagnostics and six unchanged decision-document format errors remain.Additional synthetic write/restart acceptance (Simulator). On the preserved encrypted/offline
run-bfixture, one real Capture/Send passed canonical Timeline/Detail readback, then both readbacks after process restart with the same candidate binary, container, support root, fixture and memory-only keys. Documented temporary READWRITE preparation generated only WAL/SHM; the connection closed/exited before Capture, with main-DB hash/mtime and fixture/catalog unchanged. No post-write preparation, installation, copying or reseeding; no source changes. The oracle was final editor text frozen before Send, after iOS sentence capitalization; initial lowercase-input byte fidelity was not tested. Protected Lambda RTC remained untouched and passed its fresh empty-outbox gate. This is narrow local correctness evidence, not startup-performance, remote-sync or crash-durability evidence.Unattributed UI observation: after Timeline scrolling, the top row overlapped its date header before and after restart. No matched-baseline comparison, attribution to owner isolation or fix was attempted; the write/readback pass is not blanket UI acceptance.
Experimental host-restamp remains
cross_abi_validated=false. Device/target-native ABI, exact compositor/no-recording pixels, live-account writing/outbox/remote sync, cross-account/graph changes, fault-injected UI, crash/power-loss durability and long-background reclamation are not validated. Native stop acceptance is not a worker-Idle guarantee. This preserves the explicitly reviewed admission boundary, not byte-for-byte equivalence of all asynchronous schedules.Based on #158's branch to keep this PR's diff limited to owner isolation; #158 itself is unchanged. No Dune/spec/interface or pinned LUI checkout changes.
Link to Devin session: https://app.devin.ai/sessions/7a5eed6555b64cd682e8abd3905c930f
Open in Devin Desktop: https://app.devin.ai/desktop/session/7a5eed6555b64cd682e8abd3905c930f?variant=devin
Requested by: @RCmerci