Repository navigation
fix: preserve restored sessions and pending media reads - #161
Merged
Merged
Conversation
RCmerci
marked this pull request as ready for review
November 10, 2026 12:47
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression scope
The first-confirmation decision is owned by the real worker service and its latest-control queue; the pure Sync reducer already preserves generations. These regressions therefore use the existing service/runtime boundary. Media and offline asset adapters own the pending read slots and resource retirement not represented in the pure coordinator or policy reducers. Existing pure coordinator rebind, sealed-continuation, and durable-operation regressions remain required.
Tests cover same-user restoration online/offline, duplicate confirmation, changed account, signout, admitted/coalesced A→B→A and A→signout→A, full/cancelled control admissions, outstanding reads, old graph capabilities, shared dependency consumers, queued and admitted media reads, offline scan ownership, cleanup ordering, and sealed-cursor rejection. The full existing durable-operation suite also passes.
Validation
dune build @all app/native_embed.exe.o.dune runtest --force, 22 Alcotest suites / 1340 cases plus custom runtime suites.git diff --check.40aabc0a0171c3dc5faa3e0ff9e753284465cfd0.cross_abi_validated=false. This is not live-login or real-device/full iOS ABI validation. The exact delayed-baseline identity/media race is covered at deterministic service/coordinator/adapter boundaries, not reproduced in GUI.spec-dev-tool check --allbecause the tool is unavailable.Base: current
mainat1a7f738f6416ceea4519849303674388c1f5cc8e, verified online after push. Full tests used tool-reviewed macOS localhost DNSService access; no system or security settings changed.No Dune files or spec/ OCaml files changed.