Repository navigation
Add opt-in focus-within observation for containers - #346
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?on_focus_within:(bool -> unit)torow,columnandboxso a row-owned signal can keep a comment toolbar visible while a body link or reaction has focus.FocusWithinEnableddefaults to absent/off; observation never makes the container focusable.focusin/focusoutchecks with retained-node teardown. MyGo reads committedHandle.FocusWithin(c)in its existing event queue after descendant autofocus, then publishes one initial snapshot and distinct changes, including false on disabled/inert transitions. SwiftUI, Kotlin, Generic and mobile raw-wire hosts reject opt-in rather than silently omitting events.box display=contentsat both OCaml and raw-wire admission, preserving transparent-anchor rendering without promising an absent native focus surface. Observe a real container instead; Web retains DOM-subtree observation for that combination.Checked: OCaml
@all/@runtest, schema generation and tests, Web build/unit tests, Go tests (including race)/vet and cross-builds, Swift wire build/test and Android:lui:testDebugUnitTest. Added red-green regressions for committed autofocus snapshots and transparent-box admission. No GUI validation in this slice.Link to Devin session: https://app.devin.ai/sessions/71c38037048d4f76b7cef6d695621ef6
Open in Devin Desktop: https://app.devin.ai/desktop/session/71c38037048d4f76b7cef6d695621ef6?variant=devin
Requested by: @tiensonqin