Repository navigation
ci: isolate browser caches by runner ABI - #350
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qualify the Playwright browser cache by hosted-runner
ImageOSand architecture, in addition to the locked package manifest. The existing genericLinuxkey can restore binaries built for a different distribution ABI whenubuntu-latestrolls forward.The Web job on #349 restored the existing browser cache on Ubuntu 26.04, installed ICU 78, then failed to launch cached WebKit 2336 because it requires
libicudata.so.74. Existing WebKit assertions never ran. This separate CI-only change forces an ABI-specific cache miss instead of reusing that payload; it does not change runner selection, browser/dependency versions, tests, assertions, or product code.Local validation: Ruby YAML parsing, the exact output command (
ubuntu26-X64), and whitespace/staged/full-diff checks passed. Hosted CI will verify the new cache/download and existing cross-browser suite. No new tests or test helpers.Link to Devin session: https://app.devin.ai/sessions/949a417dd06241acb1e04361de5b162b
Open in Devin Desktop: https://app.devin.ai/desktop/session/949a417dd06241acb1e04361de5b162b?variant=devin
Requested by: @tiensonqin