Repository navigation
Fix task status parity with master - #153
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align mobile capture and editor toolbar behavior with the reviewed master property rules and status cycle.
#Taskwhen setting status, scheduled, or deadline unless an existing class (including inherited classes) supplies that property.Todo → Doing → Done → empty → Todofrom the current database status, not stale UI state. Clearing status removes#Taskonly when no other task properties remain; otherwise preserve the class and store the empty placeholder.#Task.Validation:
opam exec --switch=5.5.0 -- dune build @shared/native/runtestpassed locally (1,295 tests);git diff --checkpassed. CI passed: OCaml core, Android e2e, iOS e2e, and Vendor duniverse.Native iOS UI validation passed at
7559c203on iPhone 17 / iOS 26.5 with an isolated offline graph and the real OCaml core/native renderer. Capture status/tag behavior, continuous editor toolbar cycling, both clearing paths, and app-restart persistence were exercised. Built-in Task membership was additionally checked from persisted transactions because compact rows intentionally hide that chip. Local interactive Android, hosted auth/sync, scheduled/deadline, direct Task picker capture, and the two review-specific canonical edge cases were not exercised.Link to Devin session: https://app.devin.ai/sessions/3e39d05f8d7a49cd81782d601d79b9b2
Open in Devin Desktop: https://app.devin.ai/desktop/session/3e39d05f8d7a49cd81782d601d79b9b2?variant=devin
Requested by: @tiensonqin
🟢 Devin Review found nothing to fix · View findings · Follow Devin's work