Repository navigation
Reuse bounded journal windows across title sync - #157
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep title sync from repeatedly scanning every node in a journal just to refresh the visible 32-row window. Preserve only the selected UUIDs across title/updated-at commits and local title edits, then hydrate their contents from the latest projection. Actual journal attributes drive eligibility; structural changes, non-title pending operations, title presence changes, and unbounded reads retain the existing full-read path.
This is the simpler follow-up to #156: no DataScript changes, extra runtime, thread, or sync-protocol changes. Apply/checkpoint/ACK/rebase/error ordering is unchanged. It shortens common sync jobs, not preemption of atomic structural work.
Validation: 1,297 core tests; native WebSocket command/recovery/cancellation checks; real local three-client sync stress (602 mobile operations, 82 CLI mutations, 20 assets, offline/crash/lost-ACK/server-restart recovery, matching final datoms, zero pending). One regression case compares cached and fresh journal reads across content and structural commits.
macOS real-core probe with 10,000 journal nodes: window refresh ~78ms → ~0.6ms, including a newer unsynced local title. This is not physical iPad profiling.
Link to Devin session: https://app.devin.ai/sessions/951fc198b3c140ad8b8cc8af5b531471
Open in Devin Desktop: https://app.devin.ai/desktop/session/951fc198b3c140ad8b8cc8af5b531471?variant=devin
Requested by: @tiensonqin
🟢 Devin Review found nothing to fix · View findings