Repository navigation
Show captured photos in Gallery cards - #161
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+532
to
+537
| let preview = App_test.descendant_with_extension runtime app card "outliner-block-content" in | ||
| check ~msg:"the Gallery card mounts the native photo preview" (preview <> -1); | ||
| check_eq (App_test.extension_property app preview "asset-type") | ||
| (Some (Lui_protocol.StringValue "jpeg")); | ||
| check_eq (App_test.extension_property app preview "local-path") | ||
| (Some (Lui_protocol.StringValue path)); |
There was a problem hiding this comment.
🔍 Preview test skips image decoding
The fixture never creates the JPEG. The host assertions verify extension properties, not a decoded image or the tap-to-open flow.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
Open a tag with a saved Gallery view and a tagged JPEG asset. The photo record appears as a card with its filename and properties, but no image preview mounts. A regression fixture reproduced this on main.
Changes
Verification
The tagged Gallery regression passes on both native host contracts and checks that a local capture path reaches the preview. The full OCaml gate and the iOS simulator-target Swift build passed.