Skip to content

Delete the active block from its zoomed view - #162

Merged
tiensonqin merged 1 commit into
mainfrom
codex/android-journal-block-delete
Nov 11, 2026
Merged

tiensonqin merged 1 commit into
mainfrom
codex/android-journal-block-delete

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Reproduction

On the Android emulator, zoom into a journal block and choose Delete from the overflow menu. The app opens a Delete page confirmation for the containing journal. The shared Android host regression also showed that no action targeted the zoomed block.

Changes

  • Offer Delete block on a zoomed block and confirm that the block and its children will be deleted.
  • Use the existing cursor-guarded block deletion command. Return to the parent view after success, and keep the block open if deletion fails.
  • Preserve the page delete action on page routes.

Verification

The Android host regression verifies the menu, confirmation, target UUID and navigation. The core integration test verifies that the block and its descendants are removed while the containing journal and sibling entries remain.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@tiensonqin
tiensonqin merged commit 43cbe3e into main Nov 11, 2026
5 checks passed
@tiensonqin
tiensonqin deleted the codex/android-journal-block-delete branch November 11, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant