Repository navigation
Fix clipped Android code language selector - #164
Open
tiensonqin wants to merge 1 commit into
Open
tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android code-language selector used the default Material text-button padding inside a 28 dp header, clipping the language name. Use a leading-aligned label so the native selector removes that padding and gives the text its intrinsic width. Apply the adjustment only to the Kotlin host.
Reproduced the clipping before the fix. Two Android emulator tests pass, covering complete labels for plain text, TypeScript and a longer custom language, the compact header, menu selection and multiline code editing. All 1,302 OCaml core tests pass.