Repository navigation
fix: refresh the bounded layout measurement cache - #21
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the four-entry
naturalHeightmeasurement cache current after it fills. A full-cache miss now evicts the oldest width and remembers the new result; previously every later width was recomputed recursively, making nested layouts expensive during sidebar resizing. Cache hits, partial fill, capacity and public APIs are unchanged.Only
ui/layout.gochanges (+3 lines). No caret, app, LUI or dependency-pin changes.Testing
go test ./ui, Darwin/Linux/Windowsgo build ./...andgo vet ./..., production-tag vet, formatting and diff checks passed withCGO_ENABLED=0.go test ./...is not all green: the previously reproduced clean-baselineTestLocalesmismatch (x-Testvsen-001) remains on this macOS VM.Tested on:
Windows/Linux/WASM checks above were cross-build/vet only, not runtime GUI tests.
AI disclosure
Link to Devin session: https://app.devin.ai/sessions/949a417dd06241acb1e04361de5b162b
Open in Devin Desktop: https://app.devin.ai/desktop/session/949a417dd06241acb1e04361de5b162b?variant=devin
Requested by: @tiensonqin