Repository navigation
fix: preserve trailing zero-width caret geometry - #22
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the full visible glyph advance when a shaped line ends in U+200B and the trailing anchor shares a cluster with visible text. Caret positions, hit testing and selection now use the same fraction. Ordinary clusters and existing RTL inversion are unchanged.
Four internal text files only; the sidebar measure-cache fix is not included.
Testing
CGO_ENABLED=0: the single synthetic shared-cluster regression failed before the fix and passes after it; targetedinternal/textanduitests pass.go test ./...fails onlyTestLocales(x-Testversusen-001) on BOTH this branch and cleanfca5c736; no suppression or preference changes.hellois byte-identical on all three targets. Linker-dumpdep, symbol and section comparisons attribute growth to shared native text-layout/Line metadata and ELF/PE alignment; no new opt-in dependency or callable-symbol reachability.Tested on:
AI disclosure
Link to Devin session: https://app.devin.ai/sessions/949a417dd06241acb1e04361de5b162b
Open in Devin Desktop: https://app.devin.ai/desktop/session/949a417dd06241acb1e04361de5b162b?variant=devin
Requested by: @tiensonqin