Repository navigation
fix: keep Darwin preferred languages global - #25
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
1 of 6 tasks
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read Darwin
PreferredLanguagesonly from the globalAppleLanguagesdomain. When it is absent, return an empty list rather than falling back toNSLocale.preferredLanguages, which becomes app-scoped afterSaveLocale.Remove only
TestLocales' invalid nonempty-list assumption; preserve region validation, saved-language round trips, cleanup, and the system-before/after equality invariant. No new tests, APIs, dependencies or SDK-feature changes.Testing
x-Testversusen-001); reproduced red with the existing invariant and verified green after the minimal production fix.ai.devin.mygo.locale79be43a0. The guard and application-bundle runner are outside the repository; no global/human preference writes or GUI testing.CGO_ENABLED=0 go test -count=1 -timeout 20m -exec <owned-application test runner> ./...: passed. Only the Darwin test binary is wrapped;MYGO_E2Eis absent.CGO_ENABLED=1 go test -race -count=1 -exec <owned-application test runner> ./internal/darwin: passed (race instrumentation only).mygo_noinspectorvet: Darwin arm64, Linux amd64 and Windows amd64 passed. Gofmt/diff checks passed.Tested on:
AI disclosure
Link to Devin session: https://app.devin.ai/sessions/79be43a0fc7b4ee3b783fa85566b6c1d
Open in Devin Desktop: https://app.devin.ai/desktop/session/79be43a0fc7b4ee3b783fa85566b6c1d?variant=devin
Requested by: @tiensonqin