Repository navigation
input: Expose the editor display map instead of a row count wrapper - #3495
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
EditorState::wrap_row_countwrapper added in #3483 with read-only access to the existingDisplayMapAPI. Callers query wrapped rows throughstate.display_map().wrap_row_count();prewrapcontinues to coordinate initialization before the first layout.Update the existing prewrap tests and both English and Chinese Editor docs. The sizing examples now use the theme monospace family and size to match the actual Editor rendering.
Public API
gpui-base (re-exported by gpui-component)
EditorState::display_map(&self) -> &DisplayMap: read-only access to wrapped-row counts and display-position queries.EditorState::wrap_row_count(&self) -> usize: use the existing DisplayMap query through the accessor instead.Breaking Changes
The EditorState row-count wrapper introduced in #3483 is removed:
Test Plan
cargo fmt --check.cargo check -p gpui-base.git diff --check.AI-assisted: implemented with Codex.