Redesign carbs remote screen with picker-based absorption time#567
Redesign carbs remote screen with picker-based absorption time#567
Conversation
…e hour and minute states, enhancing clarity and usability
TestSo close. The SE 2nd gen screen running iOS 18 does not show the "Done" button. The only way I know it's a "Done" button is from the code and looking at the same screen on an iPhone 15. And no, you can't scroll the screen to see the button.
Requested changeAs long as this needs work - set up variables as noted in the review. Don't hard code them as numbers. |
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Fix the screen issue for small screens. Request modifications as noted. I did not highlight every line - I think you can extrapolate.
| } | ||
|
|
||
| private var oldestAcceptedDate: Date { | ||
| Date().addingTimeInterval(-60 * 60 * 12) |
There was a problem hiding this comment.
Use a variable for the 12 hours in the past
| } | ||
|
|
||
| private var latestAcceptedDate: Date { | ||
| Date().addingTimeInterval(60 * 60) |
There was a problem hiding this comment.
Use a variable for the 1 hour in the future. Modifying this is a common customization for Loopers.
| Button(action: { | ||
| foodType = "🍭" | ||
| absorptionTimeString = "0.5" | ||
| setAbsorptionTime(hours: 0, minutes: 30) |
There was a problem hiding this comment.
set variable for the lollipop, taco, pizza "standard" aborption times. These are items to customize for Loopers. Make it easier for them.
| // Parse absorption time string to double | ||
| guard let absorptionTimeValue = Double(absorptionTimeString), absorptionTimeValue >= 0.5, absorptionTimeValue <= 8.0 else { | ||
| let selectedAbsorptionTime = absorptionTimeValue | ||
| guard selectedAbsorptionTime >= 0.5, selectedAbsorptionTime <= 8.0 else { |
There was a problem hiding this comment.
Use a variable for the min/max allowed absorption time then use it in each location instead of hard-coding it.
3 participants
Summary
Extracted from #558 to keep that PR focused on units/metrics.