Skip to content

Resume Chat history after an interrupted response body #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopx-agent merged 1 commit into from
Nov 12, 2026
Merged

Resume Chat history after an interrupted response body #8625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apps/presentation/dashboard/smoke/bound-conversation-smoke.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ try {
assert.equal(complete.messages.length, expectedRows);
const recoveredOffsets: number[] = [];
const failedOffsets = new Set<number>();
const interruptedHistoryBody = (status: number) => new Response(new ReadableStream({
start(controller) {
controller.error(new Error("Synthetic interrupted history response body"));
},
}), {status});
globalThis.fetch = async (input, init) => {
const response = await routedRead(input, init);
if (new URL(String(input), origin).pathname !== `/api/chat/sessions/${sessionId}`) return response;
Expand All @@ -140,7 +145,8 @@ try {
recoveredOffsets.push(offset);
if (offset > 0 && !failedOffsets.has(offset)) {
failedOffsets.add(offset);
throw new Error("Synthetic interrupted transport after a verified prefix");
if (offset === 200) throw new Error("Synthetic interrupted transport after a verified prefix");
return interruptedHistoryBody(response.status);
}
return response;
};
Expand All @@ -150,6 +156,8 @@ try {
assert.deepEqual(interrupted.snapshots, []);
const interruptedAgain = await fetchChatHistory(options, interrupted);
assert.deepEqual(interruptedAgain.messages, []);
assert.equal(interruptedAgain.pendingReads?.get(sessionId)?.messages.length, 400,
"A lost body after successful response headers keeps the verified prefix private");
const recovered = await fetchChatHistory(options, interruptedAgain);
assert.deepEqual(recovered.unavailableSessionIds, []);
assert.deepEqual(recovered.snapshots[0].messages, complete.messages);
Expand Down Expand Up @@ -188,11 +196,12 @@ try {
child.stdin.write("recover\n"); assert.equal((await next()).source_verified, true);
// Permanent denial, a changed source or malformed prefix cannot be retained
// as transport progress. The following read must validate page zero again.
for (const fault of ["denied", "source", "digest"]) {
for (const fault of ["denied", "denied-body", "source", "digest"]) {
globalThis.fetch = async (input, init) => {
const response = await routedRead(input, init);
if (!new URL(String(input), origin).searchParams.has("message_cursor")) return response;
if (fault === "denied") return new Response("{}", {status: 403});
if (fault === "denied-body") return interruptedHistoryBody(403);
const value = await response.json();
if (fault === "source") value.session.goal_id = "unrelated-goal";
else value.message_page.snapshot_sha256 = "0".repeat(64);
Expand Down
6 changes: 4 additions & 2 deletions apps/presentation/dashboard/src/data/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,8 +1297,10 @@ function sameHistoryRevision(current: ChatSessionSummary, read: ChatSessionSumma
}

function historyTransportUnavailable(error: unknown) {
return error instanceof ChatApiError && error.payload.error_code === "chat_api_unavailable"
&& (error.payload.http_status === undefined || Number(error.payload.http_status) >= 500);
if (!(error instanceof ChatApiError) || error.payload.error_code !== "chat_api_unavailable") return false;
const status = error.payload.http_status;
// A response body can be interrupted after successful history headers.
return status === undefined || status === 200 || Number(status) >= 500;
}

export type ChatHistory = {
Expand Down
Loading