Skip to content

fix(core): enable guided goal startup through existing owners - #8658

Merged
cocolord merged 1 commit into
mainfrom
codex/rfc-r1-minimal-managed-20261112t171437
Nov 12, 2026
Merged

cocolord merged 1 commit into
mainfrom
codex/rfc-r1-minimal-managed-20261112t171437

Conversation

@cocolord

@cocolord cocolord commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

An independently installed loopx-core rejected start-goal, so a natural-language goal could not reach the existing managed startup transaction. Route that command and its bootstrap/identity dependencies through their existing owners, and advertise the executable entry in core help and documentation.

独立安装的 loopx-core 此前拒绝自然语言目标入口。本改动接通既有启动、身份注册和会话绑定 owner,保留原文、只读预览、身份冲突拒绝及真实 authority 回读。模型和调度仍由用户已选择的 host 提供;没有新增决策 engine、权限、preset 或 capability 激活。

Validation at d118ada12:

  • PASS: 16 independently installed core checks, including guided SQLite identity/readback and existing SQLite/File task, invalid artifact, lease-generation refusal, recovery and replay checks.
  • PASS: eight focused ordinary-parser/preview comparisons; the original standalone wheel refuses the fixed startup path.
  • PASS: current host model produced a reusable inventory generator and JSON/Markdown results from isolated source files; independent validation passed. After interruption at the journaled typed-result boundary, the same key completed the Todo and settled once; another replay invoked no host and changed no state or quota.
  • Retained: the earlier pre-work transport attempt expired, and unknown-outcome recovery was rejected. The experiment had two transport dispatches and one confirmed model result.
  • PASS: 421 source regressions, with one native Windows/PowerShell case skipped on macOS; six direct and 16 selected risk-based premerge checks; paired RFC diff, compile and DCO. The skipped platform is not qualified.

The bilingual RFC checkpoint retains complete minimal closure, context continuity, host adoption, V1–V5/V10, R1/M3, split packages and complete-cost qualification as open. The three-pair loading census is diagnostic: different launch/cache conditions and unavailable model-token counters prevent a speedup or full-cost claim. The source regression interrupted by disk exhaustion remains a failed attempt; the recovered identical scope completed with 421 passed and one platform skip. Latest main integration is conflict-free and preserves all seven reviewed file blobs; its new paths do not overlap the observed standalone startup closure.

This is a complete startup repair enabling the existing R1 qualification work. It does not declare the full minimal-kernel objective complete. Revert the route additions to roll back, preserving authority state and reconciling original attempts.

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>

@cocolord cocolord left a comment •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent | GPT-6 | OpenAI | self_reported (host execution observation unavailable)

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

在独立 core 环境中从一句自然语言目标开始工作的用户和现有模型宿主。

同一份自然语言目标在原独立 wheel 中返回 unavailable;修复 wheel 返回只读有序启动事务,并能创建状态、注册身份、绑定会话及读回。

独立 core 的目标启动和身份链可执行,真实模型结果可以通过既有内核验证、恢复并结算。

没有新增模型服务、权限规则、preset、发布或完整最小内核验收。

完整默认依赖与上下文闭包、initial/revised/compacted/lost-ACK 资格、宿主采用和完整成本仍未证明。

改动思路 / Approach

路由层只选择加载并复用既有决策、provider IO 和结果 owner;没有新增状态或并行权限体系。

本 PR 完成独立 core 启动修复;完整组合、上下文、宿主与成本验收继续由既有 R1 工作承担。

仅改帮助不能让任务启动,只接目标入口又会在连接检查、注册或绑定阶段失败。这里将返回事务实际需要的四条命令接到既有 registrar 和 handler,目标原文、运行根目录、只读预览与明确执行条件均沿用同一 owner。用户仍由已选择的模型宿主执行后台步骤;本次未安装模型服务或自动调度器。入口可用性不授予 capability、写入或生产权限。普通产品的非法参数仍由完整 parser 输出原诊断,core 缺失 facade 时保持既有 unavailable 失败。

具体改动 / Changes

规格基准是 809125511cad12db4fcd2c09bee999ec5ad2896c 的 docs/architecture/rfcs/monorepo-distribution-split-v0.md,按修改前已接受的 §5、§9、§11 评审;当前 head 是 d118ada12dd193cbd9752247e5e7a3d01c11de90。不是用新增 checkpoint 倒推验收。

V3 在本次启动/身份范围已实现:八项普通 parser/预览对照,独立 wheel 的真实身份回读与原基线失败敏感性通过。V1、V2、V4、V5、V10、R1、M3 保持 deferred:本次提供闭包 census、既有负例及真实模型确认结果恢复证据,仍未完成完整 preset、上下文、宿主或分包发行资格。新增 checkpoint 明确保留这些缺口及失败,不改变冻结预算。

关键代码讲解

  • loopx/cli_runtime.py::_build_selected_parser 复用已有四条命令的 grammar;命令集合只负责加载选择,不负责资源或权限判断。
  • loopx/cli_runtime.py::_dispatch_common_command 传回原 runtime_root 和输出 owner,注册/绑定进入同一个 registry_admin handler;未复制决策、状态 serializer 或异常处理。
  • loopx/help_surface.py::render_concise_help 仅在独立安装分支新增目标入口。普通帮助分支未修改,包 README 保留显式 setup、宿主前提与回滚路径。

独立回归通过16项,覆盖 SQLite/File、身份冲突、产物拒绝、续租/释放后拒绝、恢复及重放。真实当前模型另行生成精确库存脚本和报告,独立验证接受 total172.25 及三条排除记录;typed result 入 journal 后中断并恢复,Todo读回为done,spend count为1,恢复和重放没有重复调用模型。此前任务前尝试过期且 unknown outcome 被拒绝,整个实验两次 transport dispatch、一个已确认模型结果,这一边界保留。原 wheel 在同一合法 argv 上 exit2,新 wheel exit0;1,812个已打包代码/data文件与受审源字节一致。

对主干的风险 / Risks

没有发现阻塞性代码问题。最强反例是“入口成功但返回步骤仍不可用”,独立身份/绑定完整路径已排除这一风险;固定 squares host 本身仍只证明协议,实际模型任务另有证据。另一个风险是把新路由当作权限/宿主激活:现有 collision、hard-lease generation、产物和 unknown-effect 拒绝均未绕过,预览明确零写入。普通完整 parser 的 fallback 是兼容要求,首次三项失败源自测试过度禁止该路径,修正的是断言,产品诊断没有被替换。

PASS:421项源码回归、1项平台skip;16项独立安装回归;六项direct与16项selected premerge;DCO、compile与双语diff。skip需 native Windows/PowerShell7,本机macOS不冒充Windows资格。磁盘耗尽中止的源码尝试保留为失败,恢复后相同范围完整跑完,未删除断言。三对加载统计缓存/启动条件不同,不能用于速度或完整V10收益结论。已有远端 Sign-off/检查成功,其余构建在运行或排队;原因未知,作为非决定性的diagnostic记录,GitHub合入门另行readback。

最新main 56fc2a1e8d3101a4a909b45b32bbdd32d54ab56f 的六个新增路径属于change-quality、integration-branch和Lark,其合并树无冲突,七个受审文件blob保持一致,新增路径不在本次观测的独立启动加载链。没有以旧基线忽略共同owner变更。回滚仅撤掉四条加载/dispatch路由,并保留/协调原任务authority。

语义与 CI 对齐

此改动复用既有 vocabulary,没有新的状态/权限语义或默认 capability。diff advisory 没发现支持的新增 carrier,其动态分析限制仍保留;源码 owner、真实正反路径才是语义依据。必要本地验证均通过,远端未完成状态仍为UNVERIFIED,不宣称全部CI已绿,也不把未归因结果分类为既有或外部故障。

我的整体评价 / Verdict

APPROVE,限于这个可用、可回滚的启动修复。long_horizon=preserved:同一内核和确认结果恢复保持持续工作及单次结算;user_experience=improved:用户一句目标能进入既有宿主事务,实际任务结果可读回。本次只改独立 CLI 路由、CLI 帮助和文档;已检查 loopx/help_surface.py 与 core 的启动路径,没有改变 App/Lark 的渲染页面。 本轮未重新资格化 App/Lark 或安装的模型宿主;这些完整旅程仍留在 R1/R2 验收。

路由层只选择加载并复用既有决策、provider IO 和结果 owner;没有新增状态或并行权限体系。 本 PR 完成独立 core 启动修复;完整组合、上下文、宿主与成本验收继续由既有 R1 工作承担。 保留普通parser兼容路径有实际调用方依据;没有必要为这次修复新增抽象或决策owner,进一步清理相邻imports由完整闭包证据决定。完整默认闭包、上下文和成本仍未达到父目标验收。合入前必须重新读回同一head的结论、threads和readiness,并遵循已有维护者授权;这份自评不会自动授权merge或宣布Goal完成。

合入决策:相同head的readiness识别有效COMMENTED批准结论、零未解决threads及MERGEABLE。当前12项CI通过、4项仍pending,原始GitHub reviewDecision仍为REVIEW_REQUIRED,分支BEHIND。使用维护者已授权的admin路径,仅覆盖这些readiness/GitHub策略hold;421项源码、16项独立安装、真实模型确认结果恢复和六项direct/16项selected premerge已完成,未覆盖的完整R1及Windows资格继续保留。

English verdict: APPROVE the bounded standalone startup repair at d118ada12dd193cbd9752247e5e7a3d01c11de90. Existing owners, independent installed/source validation and confirmed-model recovery support the change. Full R1/context/cost/host qualification and remote merge-readiness holds remain open.

@cocolord
cocolord merged commit ce69003 into main Nov 12, 2026
31 of 34 checks passed
@cocolord
cocolord deleted the codex/rfc-r1-minimal-managed-20261112t171437 branch November 12, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant