Repository navigation
Conversation
Lease write-scope overlap evaluated `**` as a plain fnmatch star, so the `**/` segment demanded at least one directory separator. `src/**/*.py` therefore did not overlap `src/a.py`, and `**/*.py` did not overlap `setup.py`, even though a recursive scope denotes files directly under its literal prefix as well. Two exclusive hard leases (or two atomic Todo claims) over `src/**/*.py` and `src/a.py` were both granted, so two agents could write the same file under "exclusive" leases. Read a whole-segment `**/` as zero or more directories in the folded lease overlap matcher. The case-sensitive coverage view keeps its existing plain fnmatch interpretation, and glob/glob and literal-directory comparison are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: duang777 <duangjl007@gmail.com>
Duang777
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
November 13, 2026 09:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
scopePairOverlapsintask_lease_acquire_decision.tstreated a**/segment as needing at least one directory, so a recursive glob lease and a file the glob covers were judged disjoint. That function decidestask-lease acquire, atomictodo claim, the worktree check and quota scheduling.src/**/*.pyvssrc/a.py,**/*.pyvssetup.pyanddocs/**/*.mdvsdocs/a.mdreturned no overlap, so a second agent acquired an "exclusive" lease on a file the first agent already held (acquired: true). After: they conflict (write_scope_conflict).src/**/*.pyvsdocs/a.py,src/a.mdandsrcx.pystay disjoint. Rows:regression_parity,unit.mainat7bb1b01.Author Declaration
Implemented against
scopePairOverlaps, folded matcher intask_lease_acquire_decision.tstests/control_plane_ts/task_lease_directory_scopes.test.ts,tests/control_plane/test_task_lease.py::test_write_scopes_overlap,tests/control_plane/test_canonical_lease_scopes.pyScope And Continuation
Validation
007c069051828713d3b82f684508735e907e5732for the diff; local runs used a working tree whose touched files were blob-identical tomain7bb1b01before the change.regression_paritypassedunitpassedtask_lease_directory_scopes.test.ts36/36; lease-scope Python tests pass excepttest_alias_acquire_keeps_original_request_identity_after_renewal(both providers), which failed identically without this change on the stale local tree and was not re-checked onmain.integrationnot_runmain; on the stale local tree three unrelated TS tests failed with and without this change.Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
N/A
Boundary Checklist
.loopx/,.codex/goals/, and liveACTIVE_GOAL_STATE.md).none.Signed-off-bytrailer (git commit -s).🤖 Generated with Claude Code