[pwrmgr, dv] Power manager vendoring#553
Open
csabakiss-semify wants to merge 2 commits into
Open
Conversation
csabakiss-semify
requested review from
KolosKoblasz-Semify,
marnovandermaas and
martin-velay
martin-velay
changed the title
csabakiss-semify
force-pushed
the
csk_pwrmgr_dv_port
branch
from
f5a7773 to
8620551
Compare
Contributor
martin-velay
left a comment
martin-velay
left a comment
There was a problem hiding this comment.
I have few comments so far but I'd prefer to not have that much commit to review as most of these changes I think are because of the OpenTitan hash update. Would it be possible to squash commits which come from the OT hash update? And if you have other automated code generated, it's best to have them in one commit, then I know I can just skip them from my review and focus only on your edits.
csabakiss-semify
force-pushed
the
csk_pwrmgr_dv_port
branch
2 times, most recently
from
bc35e3d to
1ed4c06
Compare
Contributor
|
@csabakiss-semify could you pull the latest |
csabakiss-semify
force-pushed
the
csk_pwrmgr_dv_port
branch
from
1ed4c06 to
a9f46f5
Compare
Contributor
|
I just checked against OT results when we run with Xcelium and we are getting similar results.
|
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
A few initial comments from my end.
Collaborator
There was a problem hiding this comment.
Did you skip number 3?
Collaborator
Author
There was a problem hiding this comment.
Yes, good catch. I had that during the development but then became useless so I removed and forgot to renumber. I’ll renumber the patches to make them cleaner.
| ''' | ||
| stage: V2S | ||
| - tests: ["pwrmgr_wakeup_reset", "pwrmgr_repeat_wakeup_reset"] | ||
| + tests: ["pwrmgr_wakeup_reset"] |
Collaborator
There was a problem hiding this comment.
What is wrong with the repeat wakeup reset test?
Collaborator
Author
There was a problem hiding this comment.
Nothing. The pwrmgr_repeat_wakeup_reset_vseq still exists, and it is used by the pwrmgr_sec_cm_lc_ctrl_intersig_mubi test. It was only that the testplan which listed pwrmgr_repeat_wakeup_reset as a test, but there is no test with that name. This patch is only to remove the stale testplan entry, not the sequence.
Signed-off-by: Csaba Kiss <csaba.kiss@semify-eda.com>
Signed-off-by: Csaba Kiss <csaba.kiss@semify-eda.com>
csabakiss-semify
force-pushed
the
csk_pwrmgr_dv_port
branch
from
a9f46f5 to
b144dc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR about the power manager block level DV vendoring.
Linked to issue #431