[doc] Update signoff checklist + add template#572
Merged
Conversation
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Definitely useful. I had a slightly different approach see: #574
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Initial review.
Merged
marnovandermaas
force-pushed
the
signoff_spec
branch
3 times, most recently
from
6eb42f2 to
dc157eb
Compare
Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org> Signed-off-by: martin-velay <mvelay@lowrisc.org>
marnovandermaas
force-pushed
the
signoff_spec
branch
from
dc157eb to
c14f29b
Compare
marnovandermaas
approved these changes
May 28, 2026
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Feel free to merge this if you're happy with it.
Contributor
Author
|
Thanks for the changes, it looks good |
Contributor
Author
|
@engdoreis, could you approve this? As I can't add myself and Marno was the last reviewer. So I need somebody else to approve in order to merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing the 1st V1 signoff (see this PR #573), I found more convenient to add some items to the list and create a template for future signoffs.