chore: migrate to NixOS 26.05 with fixes#595
Conversation
|
I'm just looking into why the the verilator build failed |
marnovandermaas
left a comment
There was a problem hiding this comment.
One change that would be good.
|
I think we need to pick a Verilator version and stick to it to avoid mismatch issues like this. I would suggest v5.040, as this is what we seemed to be used before this change. |
That's not so easy with nix, it's possible but we would have to use an overlay which means we don't get the benefit of the nix cache and everyone would have to rebuilt verilator locally. The upstream |
Is that what the OpenTitan nix shell does? It's on some ancient version I recall. |
|
I'm trying to make sense of the SYNCASYNCNET waivers (I'm not worried about the other kinds) in case we do update Verilator, but I'm struggling to figure out what they are complaining about. Bear with me while I pull this PR so I can try and see the full warning message |
Good point... it's using an old version we build in lowrisc-nix. That would pull the version back to verilator |
I think we'd need to change a lot more waivers (and possibly other things) if we were to go back to that old version |
|
Aside: You'll need to remove |
|
PR to add a new verilator 5.040 package build to lowrisc-nix: lowRISC/lowrisc-nix#186 |
|
May be irrelevant now but I'm still having trouble understanding the SYNCASYNCNET warnings. I think they are both probably fine, but the explanatory comment currently above them does not apply to them. I think they stem from some off the non-standard (but not necessarily bad) things done with reset signals in the OpenTitan reset manager code |
This flake follows the lowrisc-nix nixpkgs which has now been updated to nixos 26.05, which doesn't support Python 3.10 This commit updates to Python 3.12 and updates the flake lock to pull in the latest lowrisc-nix packages. Signed-off-by: David James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: David James McCorrie <james.mccorrie@lowrisc.org>
Thanks for looking into this @elliotb-lowrisc I've reverted to Verilator 5.040 which is now available from lowrisc-nix. So I've removed the wavers to avoid the confusion. |
elliotb-lowrisc
left a comment
There was a problem hiding this comment.
I'm no nix expert, but I approve of the intent
ziuziakowska
left a comment
There was a problem hiding this comment.
LGTM! Might be nice to add nix fmt . to CI in the future.
This flake follows the lowrisc-nix nixpkgs which has now been updated to nixos 26.05, which doesn't support Python 3.10
Update: this PR has been updated to use a pinned version of verilator rather than trying to update the wavers to get it working with the new 5.048 version packaged with NixOS 26.05.