Skip to content

fix(responses): preserve gateway citations during native compact (superseded by #752) - #751

Closed
luvs01 wants to merge 3 commits into
devfrom
fix/preserve-gateway-citations-compact
Closed

luvs01 wants to merge 3 commits into
devfrom
fix/preserve-gateway-citations-compact

Conversation

@luvs01

@luvs01 luvs01 commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Superseded by fix(responses): preserve gateway citations during native compact #752, updated in commit b095b04. The verified implementation and regression coverage are maintained there.
  • Correct the target from main to dev. The original comparison against the release branch included thousands of unrelated files; this branch's intended change is limited to three source files.
  • The intended contract is destination-specific: official OpenAI requests repair replayed citations, while a third-party gateway's native compact capability does not authorize rewriting its annotations. The replacement also evaluates this policy after queued destination reselection.

Verification

Reviewed original head 0a477e02b0348fd8af15586be1a1735388b20d24 against dev and checked its CI logs:

  • passthrough.ts imports a nonexistent ./scrubOcxCompactionItems module.
  • compact.ts removes an opening scope brace while retaining its closing brace, producing the parser/typecheck failures reported by CI.
  • The previously claimed tests/responses/compact-citations.test.ts file is absent from this head. This PR contains no test or documentation changes, so the earlier verification claims should not be treated as passing evidence.
  • See fix(responses): preserve gateway citations during native compact #752 for the corrected implementation, focused tests, typecheck, privacy and structure checks, and public documentation build.

This duplicate is being closed without merging; no validation success is claimed for its original head.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
📝 Walkthrough

[!WARNING]
Review details and warnings were omitted to fit the comment limit.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added bug Something isn't working intake: hygiene-blocked Deterministic PR hygiene checks failed labels Oct 23, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Deterministic hygiene checks failed.

  • orphan_lockfile — bun.lock changed without package.json. Revert accidental churn or obtain dependency-change-approved.

@github-actions github-actions Bot changed the title fix(responses): preserve gateway citations during native compact [WRONG BRANCH] fix(responses): preserve gateway citations during native compact Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

⏳ DRAFT

  • hygiene: missing_regression_test.

What to do

  • Fix missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft October 23, 2026 09:47
@luvs01

luvs01 commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

No description provided.

@luvs01 luvs01 changed the title [WRONG BRANCH] fix(responses): preserve gateway citations during native compact fix(responses): preserve gateway citations during native compact (superseded by #752) Oct 23, 2026
@luvs01
luvs01 changed the base branch from main to dev October 23, 2026 09:58
@luvs01 luvs01 closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working intake: hygiene-blocked Deterministic PR hygiene checks failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant