Repository navigation
Conversation
Collaborator
|
Thank you for making a new PR. Unfortunately, I'm not qualified to review this area. But hopefully one of the other two will be along shortly. |
…nknownHostException
This comment was marked as spam.
This comment was marked as spam.
Collaborator
|
@omers-oai LLM-written comments are not allowed per the contribution policy. You were already warned once and are now banned. I'm not sure if the PR will stay open or not, but I will attempt to leave it open. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9557 introduced this regression by creating a Dns.Request earlier in the code. (See here).
This means that an
IllegalArgumentExceptionis now thrown for malformed hostnames, making the asynchronous dispatcher rethrow and crash the app I work on (and affecting others: #9758).To fix it, let's catch and replace it with an
UnknownHostExceptionwhich matches this problem better and was the original expected exception for this event.Added the unit test proposed in the issue, another local test and tested on my app to make sure it fixes the issue.