Repository navigation
Labels
bugSomething isn't workingSomething isn't working
Description
Several bugs in the editor and the label pages.
- Deleted notes are editable (regression of v2.1.2):
readOnly = !currentNote.deleted && …makes the editor editable precisely for the notes in the bin. - An edited archived note appears in the main list: the editor and the title always save through
notesProvider(status: available), which adds the archived note to its state until the next reload. - Label filter reset when switching labels:
currentLabelFilteris global. WithgoNamed, the page of label B is created before the page of label A is disposed, and A'sdisposesets the filter back tonull. On label B, edits, new notes and the search then target all the notes. - A note created on a label page doesn't get that label: it shows in the label's list, then disappears at the next reload.
- Keyboard closing when creating a note with several note types (probably Note focus lost on opening when multiple notes types are available #571): the expandable FAB is closed after the editor is pushed.
closeAddNoteFabIfOpenalso ignores the FAB of the label pages. - Undo / redo not updating after a formatting action (Undo/redo buttons don't update appropriately #565): fleather pushes to its history with a 500 ms throttle, but
canUndo/canRedoare only read right when the document changes. - Smaller ones:
- "Next" on the title keyboard doesn't move to the content (
onSubmitted: (_) => widget.onSubmittednever calls it). - The title creates a new
TextEditingControlleron each build, and the editors' controllers are never disposed. setDeletedtogglesnote.deletedinstead of setting it.- Undoing the deletion of several archived notes uses a widget
refthat may be disposed, and shows a second snack bar. - A malformed Markdown link throws a
FormatException. setArchivedandtoggleLockremove the empty notes from the list they receive (the selection).
- "Next" on the title keyboard doesn't move to the content (
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Projects
- StatusShow more project fieldsDone
Activity
fix(editor): make deleted notes read only and save archived notes in …
fix(labels): keep the label filter when switching from a label to ano…
fix(labels): add the label of the page to the notes created from it
fix(notes): close the add note FAB before opening the editor
fix(editor): update the undo and redo buttons after fleather updates …
fix(editor): move to the content when submitting the title, and keep …
fix(editor): dispose the controllers of the editors
fix(editor): ignore malformed links in Markdown notes
refactor(notes): set the deleted state of the notes instead of toggli…
fix(notes): fix the undo of the deletion of several archived notes
fix(notes): leave the caller's list unchanged when ignoring empty notes