Skip to content

Small fixes: export frequency text, migrations, title sort, dead code #588

Open

Description

@maelchiotti
  • Export frequency of 3 days shows "Every ": settings_auto_export_frequency_value has no 3 case, although 3 days is one of the slider values (automaticExportFrequenciesValues). This affects every language.
  • Migrations not atomic: the database migrations to v2 and v3 remove the notes, then put them back, in separate transactions (the clear() of v2 even runs outside any transaction). The v3 migration changes the id of each note, so its label links, stored by id, are lost. This only affects users updating from very old versions.
  • Sort by title is case-sensitive: "b" comes after "Z", unlike the sort of the labels.
  • Dead code: PreferenceKey.preferenceSecure always throws an ArgumentError (it calls get on a securely stored key) and is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinglocalizationImprovements or additions to localizations

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions