Repository navigation
Conversation
…elayed Measured 2026-11-19 on auto/glm-5.3 through magpie: the model answered a whole agent turn as the terminal's own tool action envelope — a review with a tool payload — and it reached the agent as the answer text with a 200, which nothing could fail over on. The request went up with tools: [], so the tool it asks for cannot be run, and the object is that client's protocol, not an answer an OpenAI client can use. The envelope never streams before it is whole, and the turn ends as the error frame magpie fails over on (text_tool_call), the same treatment as TEXT_CALL, trae (plugins#38) and qoder (plugins#132). A model with more than one thing to ask for writes the envelopes one after another (measured the same evening); the whole run is held and refused, including when the stream ends inside a later member of it.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured 2026-11-19 on
auto/glm-5.3through magpie: the model answered a whole agent turn as the OrcaTerm terminal's own tool action envelope —{"action":"review","ph_1":"--","tool":{"type":"mcp","mcpServer":"mcp-server-orcaterm-oauth","name":"execute_command","args":{"command":"ls …"}}}— and it reached the agent as the answer text with a 200, which nothing could fail over on (three turns in one session; the agent read the protocol object as prose and carried on as if the tool had run).
Nothing can honour it:
toUpstreamBodysendstools: [], so thetoolit asks for cannot be run, and the object is that client's protocol, not an answer an OpenAI client can use.This PR holds the envelope — it never streams before it is whole — and ends the turn as the error frame magpie fails over on (
text_tool_call), the same treatment asTEXT_CALL, trae (#38) and qoder (#132):reviewcarrying ataskCompletionstays an answer, an envelope quoted as an example with text after it stays prose, and a truncated envelope on its own stays texttoolenvelope.test.mjscovers all of it (14 tests, bytes of the measured reply). The one failing test in the suite (/cbrebinding) fails on this machine onmainas well, without this branch.